koord-descheduler: stop migration when reserved on the same node#519
Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom Aug 24, 2022
Conversation
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Codecov Report
@@ Coverage Diff @@
## main #519 +/- ##
==========================================
+ Coverage 67.91% 67.98% +0.07%
==========================================
Files 155 155
Lines 16504 16526 +22
==========================================
+ Hits 11208 11235 +27
+ Misses 4464 4458 -6
- Partials 832 833 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joseph joseph.t.lee@outlook.com
Ⅰ. Describe what this PR does
When scheduler assigned the Reservation on the same node as the Pod, Migration controller should stop the job.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test