Skip to content

koord-scheduler: add coscheduling plugin args#538

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
buptcozy:enhance_coescheduling_apis
Aug 29, 2022
Merged

koord-scheduler: add coscheduling plugin args#538
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
buptcozy:enhance_coescheduling_apis

Conversation

@Wenshiqi222
Copy link
Contributor

Signed-off-by: wenshiqi wen470366661@163.com

Ⅰ. Describe what this PR does

add the apis for coescheduling

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot koordinator-bot bot requested review from FillZpp and hormes August 26, 2022 03:13
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #538 (6c4b47d) into main (5a50dbb) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #538      +/-   ##
==========================================
+ Coverage   67.34%   67.40%   +0.05%     
==========================================
  Files         163      163              
  Lines       17354    17354              
==========================================
+ Hits        11687    11697      +10     
+ Misses       4808     4799       -9     
+ Partials      859      858       -1     
Flag Coverage Δ
unittests 67.40% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/httputil/reverseproxy.go 85.10% <0.00%> (+0.79%) ⬆️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 78.94% <0.00%> (+7.36%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eahydra eahydra self-requested a review August 26, 2022 03:43
Signed-off-by: wenshiqi <wen470366661@163.com>
@Wenshiqi222 Wenshiqi222 force-pushed the enhance_coescheduling_apis branch from b7c3099 to 6c4b47d Compare August 26, 2022 06:47
@eahydra eahydra changed the title enhance coescheduling apis koord-scheduler: add coscheduling plugin args Aug 26, 2022
@eahydra
Copy link
Member

eahydra commented Aug 26, 2022

/lgtm

@buptcozy
Copy link
Contributor

/LGTM

@koordinator-bot
Copy link

@buptcozy: changing LGTM is restricted to collaborators

Details

In response to this:

/LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eahydra eahydra linked an issue Aug 26, 2022 that may be closed by this pull request
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jasonliu747 jasonliu747 added this to the v0.7 milestone Aug 26, 2022
@hormes
Copy link
Member

hormes commented Aug 29, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 25d0ea7 into koordinator-sh:main Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants