Skip to content

koord-scheduler: support custom SharedLister#549

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
ZiMengSheng:support_custom_snapshotlister
Aug 29, 2022
Merged

koord-scheduler: support custom SharedLister#549
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
ZiMengSheng:support_custom_snapshotlister

Conversation

@ZiMengSheng
Copy link
Member

Signed-off-by: wangjianyu zmsjianyu@gmail.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot koordinator-bot bot requested review from eahydra and hormes August 29, 2022 09:37
@jasonliu747 jasonliu747 added this to the v0.7 milestone Aug 29, 2022
Signed-off-by: wangjianyu <zmsjianyu@gmail.com>
@ZiMengSheng ZiMengSheng force-pushed the support_custom_snapshotlister branch from 37ccd09 to 565c172 Compare August 29, 2022 10:07
@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #549 (565c172) into main (bd3a7e3) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #549      +/-   ##
==========================================
+ Coverage   67.38%   67.40%   +0.01%     
==========================================
  Files         163      163              
  Lines       17354    17354              
==========================================
+ Hits        11694    11697       +3     
+ Misses       4801     4799       -2     
+ Partials      859      858       -1     
Flag Coverage Δ
unittests 67.40% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/httputil/reverseproxy.go 85.10% <0.00%> (+0.79%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hormes
Copy link
Member

hormes commented Aug 29, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit e3bccb0 into koordinator-sh:main Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants