Skip to content

New feature: cpu burst strategy#73

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
stormgbs:main
Apr 24, 2022
Merged

New feature: cpu burst strategy#73
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
stormgbs:main

Conversation

@stormgbs
Copy link
Member

@stormgbs stormgbs commented Apr 14, 2022

Signed-off-by: stormgbs stormgbs@gmail.com

Ⅰ. Describe what this PR does

New feature: cpu burst strategy

Ⅱ. Does this pull request fix one issue?

#52

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@hormes
Copy link
Member

hormes commented Apr 17, 2022

/retest

@jasonliu747
Copy link
Member

@stormgbs Hi, I have skipped the unit test Test_metaService_syncPods in #80. Please rebase your code and push it again. Sorry for any inconvenience.

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2022

Codecov Report

Merging #73 (31bbf60) into main (b84b987) will increase coverage by 3.25%.
The diff coverage is 60.75%.

@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   40.66%   43.92%   +3.25%     
==========================================
  Files          66       71       +5     
  Lines        5144     5860     +716     
==========================================
+ Hits         2092     2574     +482     
- Misses       2804     2996     +192     
- Partials      248      290      +42     
Flag Coverage Δ
unittests 43.92% <60.75%> (+3.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/resmanager/resmanager.go 3.00% <0.00%> (+3.00%) ⬆️
pkg/util/container.go 26.81% <0.00%> (-2.56%) ⬇️
pkg/util/system/cgroup.go 70.00% <0.00%> (-9.55%) ⬇️
pkg/util/system/cgroup_resource.go 0.00% <0.00%> (ø)
pkg/util/system/common.go 52.38% <0.00%> (-43.28%) ⬇️
pkg/util/utils.go 65.33% <0.00%> (-10.06%) ⬇️
pkg/koordlet/resmanager/metrics_query.go 53.68% <39.53%> (+53.68%) ⬆️
pkg/koordlet/resmanager/types.go 41.53% <41.53%> (ø)
...kg/koordlet/resmanager/resource_update_executor.go 43.05% <43.05%> (ø)
pkg/tools/cache/expiration_cache.go 70.90% <70.90%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b84b987...31bbf60. Read the comment docs.

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a document about which linux kernel should user use if they wanna enable CPU burst.

Signed-off-by: stormgbs <stormgbs@gmail.com>
@zwzhang0107
Copy link
Contributor

/lgtm

@jasonliu747
Copy link
Member

/hold

@hormes hormes added this to the v0.3 milestone Apr 19, 2022
@zwzhang0107
Copy link
Contributor

/hold cancel

@hormes
Copy link
Member

hormes commented Apr 24, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 38d9e77 into koordinator-sh:main Apr 24, 2022
@jasonliu747 jasonliu747 removed this from the v0.3 milestone May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants