Skip to content

proposal: enhanced scheduler extension#742

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
eahydra:add_scheduler_extension_design_proposal
Nov 10, 2022
Merged

proposal: enhanced scheduler extension#742
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
eahydra:add_scheduler_extension_design_proposal

Conversation

@eahydra
Copy link
Member

@eahydra eahydra commented Oct 25, 2022

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

Supplement the lack of proposals on enhancing the scheduler extension mechanism.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Base: 68.14% // Head: 68.10% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (4fce3ee) compared to base (339a4a2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #742      +/-   ##
==========================================
- Coverage   68.14%   68.10%   -0.04%     
==========================================
  Files         212      212              
  Lines       24112    24112              
==========================================
- Hits        16431    16422       -9     
- Misses       6548     6553       +5     
- Partials     1133     1137       +4     
Flag Coverage Δ
unittests 68.10% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/runtimehooks/reconciler/reconciler.go 71.57% <0.00%> (-7.37%) ⬇️
pkg/util/httputil/reverseproxy.go 84.30% <0.00%> (-0.54%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra force-pushed the add_scheduler_extension_design_proposal branch from c5d6c19 to 4fce3ee Compare November 9, 2022 17:15
@eahydra eahydra requested a review from hormes November 9, 2022 17:16
@hormes
Copy link
Member

hormes commented Nov 10, 2022

/lgtm

Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: FillZpp, saintube

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 10f8e50 into koordinator-sh:main Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants