koordlet: runtime hook support failpolicy#773
koordlet: runtime hook support failpolicy#773koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
Conversation
Codecov ReportBase: 67.50% // Head: 67.56% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #773 +/- ##
==========================================
+ Coverage 67.50% 67.56% +0.05%
==========================================
Files 241 246 +5
Lines 27982 28172 +190
==========================================
+ Hits 18889 19034 +145
- Misses 7793 7836 +43
- Partials 1300 1302 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
b5668a4 to
8f62326
Compare
|
@huiwq1990 What do you think about the above suggestion? |
8f62326 to
b702600
Compare
b702600 to
4d152e7
Compare
|
@hormes I just fix them. |
4d152e7 to
0057f2f
Compare
0057f2f to
e4250f3
Compare
There was a problem hiding this comment.
Need we use else condition? May log the warning message directly?
|
/lgtm |
Signed-off-by: huiwq1990 <huiwq1990@163.com>
e4250f3 to
ca24657
Compare
|
@zwzhang0107 Why upload coverage to codecov failed? |
|
seems the network problem, can be fixed by retry |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test