Skip to content

koordlet: runtime hook support failpolicy#773

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
huiwq1990:feat-runtimehook-failpolicy
Feb 8, 2023
Merged

koordlet: runtime hook support failpolicy#773
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
huiwq1990:feat-runtimehook-failpolicy

Conversation

@huiwq1990
Copy link
Contributor

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Base: 67.50% // Head: 67.56% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (ca24657) compared to base (65849ae).
Patch coverage: 85.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #773      +/-   ##
==========================================
+ Coverage   67.50%   67.56%   +0.05%     
==========================================
  Files         241      246       +5     
  Lines       27982    28172     +190     
==========================================
+ Hits        18889    19034     +145     
- Misses       7793     7836      +43     
- Partials     1300     1302       +2     
Flag Coverage Δ
unittests 67.56% <85.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/runtimehooks/runtimehooks.go 68.11% <72.72%> (-2.20%) ⬇️
pkg/koordlet/runtimehooks/config.go 100.00% <100.00%> (ø)
pkg/koordlet/runtimehooks/reconciler/reconciler.go 61.76% <0.00%> (-4.12%) ⬇️
pkg/scheduler/plugins/loadaware/load_aware.go 73.81% <0.00%> (-3.28%) ⬇️
pkg/scheduler/plugins/coscheduling/core/gang.go 77.28% <0.00%> (-0.95%) ⬇️
...ler/apis/config/validation/validation_loadaware.go 0.00% <0.00%> (ø)
pkg/descheduler/utils/anomaly/types.go 0.00% <0.00%> (ø)
pkg/scheduler/plugins/loadaware/estimator/types.go 0.00% <0.00%> (ø)
pkg/descheduler/utils/anomaly/basic_detector.go 89.24% <0.00%> (ø)
...r/plugins/loadaware/estimator/default_estimator.go 97.91% <0.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@huiwq1990 huiwq1990 force-pushed the feat-runtimehook-failpolicy branch from b5668a4 to 8f62326 Compare November 2, 2022 00:33
@hormes hormes requested a review from honpey November 10, 2022 03:05
@hormes
Copy link
Member

hormes commented Nov 24, 2022

@huiwq1990 What do you think about the above suggestion?

@huiwq1990 huiwq1990 force-pushed the feat-runtimehook-failpolicy branch from 8f62326 to b702600 Compare November 29, 2022 06:55
@koordinator-bot koordinator-bot bot added size/L and removed size/M labels Nov 29, 2022
@huiwq1990 huiwq1990 force-pushed the feat-runtimehook-failpolicy branch from b702600 to 4d152e7 Compare November 29, 2022 13:30
@huiwq1990
Copy link
Contributor Author

@hormes I just fix them.

@jasonliu747 jasonliu747 changed the title runtime hook support failpolicy koordlet: runtime hook support failpolicy Nov 30, 2022
@huiwq1990 huiwq1990 force-pushed the feat-runtimehook-failpolicy branch from 4d152e7 to 0057f2f Compare January 9, 2023 00:36
@huiwq1990 huiwq1990 force-pushed the feat-runtimehook-failpolicy branch from 0057f2f to e4250f3 Compare February 6, 2023 13:14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need we use else condition? May log the warning message directly?

@zwzhang0107
Copy link
Contributor

/lgtm

Signed-off-by: huiwq1990 <huiwq1990@163.com>
@huiwq1990 huiwq1990 force-pushed the feat-runtimehook-failpolicy branch from e4250f3 to ca24657 Compare February 7, 2023 08:17
@koordinator-bot koordinator-bot bot removed the lgtm label Feb 7, 2023
@huiwq1990
Copy link
Contributor Author

@zwzhang0107 Why upload coverage to codecov failed?

@zwzhang0107
Copy link
Contributor

seems the network problem, can be fixed by retry

@zwzhang0107
Copy link
Contributor

/lgtm
/approve

@koordinator-bot koordinator-bot bot added the lgtm label Feb 8, 2023
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 2e9b956 into koordinator-sh:main Feb 8, 2023
@zwzhang0107 zwzhang0107 added this to the v1.2 milestone Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants