Skip to content

koord-manager: update RBAC#779

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
eahydra:fix_koord_manager_rbac
Nov 2, 2022
Merged

koord-manager: update RBAC#779
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
eahydra:fix_koord_manager_rbac

Conversation

@eahydra
Copy link
Member

@eahydra eahydra commented Nov 2, 2022

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

Supplement RBAC missed by koord-manager.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@koordinator-bot koordinator-bot bot requested review from FillZpp and saintube November 2, 2022 13:21
@eahydra eahydra requested a review from hormes November 2, 2022 13:21
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Base: 68.22% // Head: 68.21% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (5b0e30e) compared to base (bf60609).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #779      +/-   ##
==========================================
- Coverage   68.22%   68.21%   -0.02%     
==========================================
  Files         210      210              
  Lines       24120    24120              
==========================================
- Hits        16456    16453       -3     
- Misses       6520     6522       +2     
- Partials     1144     1145       +1     
Flag Coverage Δ
unittests 68.21% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...controller/noderesource/noderesource_controller.go 42.46% <ø> (ø)
...webhook/pod/mutating/cluster_colocation_profile.go 55.97% <ø> (ø)
pkg/util/httputil/reverseproxy.go 84.30% <0.00%> (-0.80%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hormes
Copy link
Member

hormes commented Nov 2, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 94913ea into koordinator-sh:main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants