Skip to content

koord-scheduler: fix ElasticQuota plugin don't clean node cache when node delete#784

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
fjding:fix-clean-cache
Nov 5, 2022
Merged

koord-scheduler: fix ElasticQuota plugin don't clean node cache when node delete#784
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
fjding:fix-clean-cache

Conversation

@fjding
Copy link
Contributor

@fjding fjding commented Nov 3, 2022

Ⅰ. Describe what this PR does

fix #771

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 68.16% // Head: 68.16% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (0d18428) compared to base (94913ea).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #784      +/-   ##
==========================================
- Coverage   68.16%   68.16%   -0.01%     
==========================================
  Files         210      210              
  Lines       24084    24085       +1     
==========================================
  Hits        16418    16418              
- Misses       6525     6526       +1     
  Partials     1141     1141              
Flag Coverage Δ
unittests 68.16% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/plugins/elasticquota/node_handler.go 68.18% <100.00%> (+0.48%) ⬆️
pkg/koordlet/statesinformer/states_pods.go 54.60% <0.00%> (-2.13%) ⬇️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 81.05% <0.00%> (+2.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eahydra eahydra changed the title koord-scheduler: fix elasticquota plugin don't clean node cache when… koord-scheduler: fix elasticquota plugin don't clean node cache when node delete Nov 4, 2022
@eahydra eahydra changed the title koord-scheduler: fix elasticquota plugin don't clean node cache when node delete koord-scheduler: fix ElasticQuota plugin don't clean node cache when node delete Nov 4, 2022
… node delete (koordinator-sh#771)

Signed-off-by: fjding <dingfangjie@bytedance.com>
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: eahydra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FillZpp
Copy link
Member

FillZpp commented Dec 13, 2022

/milestone v1.1

@koordinator-bot koordinator-bot bot added this to the v1.1 milestone Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]elasticquota when remove node A, then add node A come back, the totalResource will not update

3 participants