Skip to content

chore: refactor cpuset in package for code reuse#793

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
eahydra:reuse_cpuset
Nov 9, 2022
Merged

chore: refactor cpuset in package for code reuse#793
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
eahydra:reuse_cpuset

Conversation

@eahydra
Copy link
Member

@eahydra eahydra commented Nov 9, 2022

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

There are multiple implementations of cpuset in the current code, which are now refactored and integrated.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Check failure

Code scanning / CodeQL

Incorrect conversion between integer types

Incorrect conversion of an integer with architecture-dependent bit size from [strconv.Atoi](1) to a lower bit size type int32 without an upper bound check. Incorrect conversion of an integer with architecture-dependent bit size from [strconv.Atoi](2) to a lower bit size type int32 without an upper bound check.
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Base: 68.19% // Head: 68.08% // Decreases project coverage by -0.11% ⚠️

Coverage data is based on head (5a839fd) compared to base (650dcd2).
Patch coverage: 77.65% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #793      +/-   ##
==========================================
- Coverage   68.19%   68.08%   -0.12%     
==========================================
  Files         211      211              
  Lines       24102    24080      -22     
==========================================
- Hits        16437    16395      -42     
- Misses       6526     6550      +24     
+ Partials     1139     1135       -4     
Flag Coverage Δ
unittests 68.08% <77.65%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dlet/statesinformer/states_noderesourcetopology.go 63.98% <ø> (ø)
...r/plugins/nodenumaresource/cpu_topology_manager.go 100.00% <ø> (ø)
pkg/scheduler/plugins/nodenumaresource/plugin.go 63.04% <ø> (ø)
...heduler/plugins/nodenumaresource/plugin_service.go 77.77% <ø> (ø)
...scheduler/plugins/nodenumaresource/cpu_topology.go 53.79% <30.43%> (ø)
.../scheduler/plugins/nodenumaresource/cpu_manager.go 73.52% <66.66%> (ø)
...eduler/plugins/nodenumaresource/cpu_accumulator.go 83.01% <80.00%> (ø)
pkg/koordlet/resmanager/cpu_suppress.go 69.65% <83.33%> (ø)
...heduler/plugins/nodenumaresource/cpu_allocation.go 95.74% <100.00%> (ø)
...duler/plugins/nodenumaresource/pod_eventhandler.go 59.15% <100.00%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eahydra eahydra requested a review from saintube November 9, 2022 06:42
@zwzhang0107
Copy link
Contributor

/lgtm

@ZiMengSheng
Copy link
Member

/lgtm

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: saintube, ZiMengSheng
To complete the pull request process, please assign hormes after the PR has been reviewed.
You can assign the PR to them by writing /assign @hormes in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 949e303 into koordinator-sh:main Nov 9, 2022
@FillZpp
Copy link
Member

FillZpp commented Dec 13, 2022

/milestone v1.1

@koordinator-bot koordinator-bot bot added this to the v1.1 milestone Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants