Skip to content

Add jasonliu747 into approvers alias#809

Merged
koordinator-bot[bot] merged 1 commit intomainfrom
jasonliu747-patch-1
Nov 15, 2022
Merged

Add jasonliu747 into approvers alias#809
koordinator-bot[bot] merged 1 commit intomainfrom
jasonliu747-patch-1

Conversation

@jasonliu747
Copy link
Member

Signed-off-by: Jason Liu jasonliu747@gmail.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: Jason Liu <jasonliu747@gmail.com>
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Base: 67.90% // Head: 67.88% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (27155fd) compared to base (79c421a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #809      +/-   ##
==========================================
- Coverage   67.90%   67.88%   -0.03%     
==========================================
  Files         216      216              
  Lines       24368    24368              
==========================================
- Hits        16548    16541       -7     
- Misses       6672     6679       +7     
  Partials     1148     1148              
Flag Coverage Δ
unittests 67.88% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/runtimehooks/reconciler/reconciler.go 71.57% <0.00%> (-7.37%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@koordinator-bot koordinator-bot bot merged commit 4470098 into main Nov 15, 2022
@jasonliu747 jasonliu747 deleted the jasonliu747-patch-1 branch November 15, 2022 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant