Skip to content

koord-scheduler: make ForceSyncFromInformer easier to use#876

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
eahydra:refactor_forcesynced_handler
Dec 12, 2022
Merged

koord-scheduler: make ForceSyncFromInformer easier to use#876
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
eahydra:refactor_forcesynced_handler

Conversation

@eahydra
Copy link
Member

@eahydra eahydra commented Dec 10, 2022

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

Make ForceSyncFromInformer easier to use.

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@codecov
Copy link

codecov bot commented Dec 10, 2022

Codecov Report

Base: 66.45% // Head: 66.45% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (b0282e7) compared to base (4c843e3).
Patch coverage: 43.75% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #876      +/-   ##
==========================================
- Coverage   66.45%   66.45%   -0.01%     
==========================================
  Files         233      233              
  Lines       26512    26523      +11     
==========================================
+ Hits        17618    17625       +7     
- Misses       7665     7668       +3     
- Partials     1229     1230       +1     
Flag Coverage Δ
unittests 66.45% <43.75%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...heduler/frameworkext/helper/synced_eventhandler.go 75.75% <43.75%> (-7.88%) ⬇️
pkg/koordlet/statesinformer/states_pods.go 56.73% <0.00%> (+2.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eahydra eahydra requested a review from ZiMengSheng December 12, 2022 02:15
@ZiMengSheng
Copy link
Member

/lgtm

@eahydra
Copy link
Member Author

eahydra commented Dec 12, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra, ZiMengSheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 5b240e0 into koordinator-sh:main Dec 12, 2022
@FillZpp
Copy link
Member

FillZpp commented Dec 13, 2022

/milestone v1.1

@koordinator-bot koordinator-bot bot added this to the v1.1 milestone Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants