koord-schedler: fix queuesortplugin of coscheduling

[lucming]

Ⅰ. Describe what this PR does

coscheduling.Less, the id of the pg should be compared, and the old logic is compare with {pod.namespace}/{pod.name} maybe not right.
Our ultimate goal should be to put pods belonging to the same pg together in schedulerqueue.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

• I have written necessary docs and comments
• I have added necessary unit tests and integration tests
• All checks passed in make test

[koordinator-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign buptcozy after the PR has been reviewed.
You can assign the PR to them by writing /assign @buptcozy in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• pkg/scheduler/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Base: 66.44% // Head: 66.44% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (120309a) compared to base (843c19b).
Patch coverage: 28.57% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #894      +/-   ##
==========================================
- Coverage   66.44%   66.44%   -0.01%     
==========================================
  Files         233      233              
  Lines       26754    26772      +18     
==========================================
+ Hits        17778    17788      +10     
- Misses       7717     7725       +8     
  Partials     1259     1259              

Flag	Coverage Δ
unittests	66.44% <28.57%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/scheduler/plugins/coscheduling/core/core.go	37.78% <0.00%> (-1.95%)	⬇️
pkg/scheduler/plugins/coscheduling/core/gang.go	75.47% <100.00%> (+1.02%)	⬆️
.../scheduler/plugins/coscheduling/core/gang_cache.go	75.14% <100.00%> (+0.29%)	⬆️
pkg/scheduler/plugins/coscheduling/coscheduling.go	70.10% <100.00%> (ø)
pkg/util/httputil/reverseproxy.go	84.30% <0.00%> (-0.80%)	⬇️
pkg/koordlet/runtimehooks/reconciler/reconciler.go	65.88% <0.00%> (+4.11%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[eahydra]

Hi @lucming , It is also strange that this PR uses PodGroup UID as one of the sorting conditions, especially when the sorting condition of the time dimension is also removed.

I think your problem should be solved by #873 . You can take a look at the code of this PR.

[lucming]

Hi @lucming , It is also strange that this PR uses PodGroup UID as one of the sorting conditions, especially when the sorting condition of the time dimension is also removed.

I think your problem should be solved by #873 . You can take a look at the code of this PR.

okay, i will close this pr. IMO,we just want something to make sure the pod in the same pg, pg.uid maybe can use directly, is it not necessary to regenerate a hash code? Of course that's fine, I'm just giving my opinion.

[eahydra]

Hi @lucming , It is also strange that this PR uses PodGroup UID as one of the sorting conditions, especially when the sorting condition of the time dimension is also removed.
I think your problem should be solved by #873 . You can take a look at the code of this PR.

okay, i will close this pr. IMO,we just want something to make sure the pod in the same pg, pg.uid maybe can use directly, is it not necessary to regenerate a hash code? Of course that's fine, I'm just giving my opinion.

yeah...The hash code is not necessary, I understand that it is just for comparison.

[eahydra]

/close
resolved by #873

[koordinator-bot]

@eahydra: Closed this PR.

Details

In response to this:

/close
resolved by #873

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.