Skip to content

koord-scheduler: fix reservation doesn't match pod when hostport is not set#916

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
KunWuLuan:fix-hostpath-0
Jan 3, 2023
Merged

koord-scheduler: fix reservation doesn't match pod when hostport is not set#916
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
KunWuLuan:fix-hostpath-0

Conversation

@KunWuLuan
Copy link
Member

No description provided.

is not specified

Signed-off-by: KunWuLuan <kunwuluan@gmail.com>
@codecov
Copy link

codecov bot commented Jan 2, 2023

Codecov Report

Base: 66.63% // Head: 66.66% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (51ae870) compared to base (52c3fa8).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #916      +/-   ##
==========================================
+ Coverage   66.63%   66.66%   +0.02%     
==========================================
  Files         240      240              
  Lines       27769    27769              
==========================================
+ Hits        18505    18513       +8     
+ Misses       7992     7983       -9     
- Partials     1272     1273       +1     
Flag Coverage Δ
unittests 66.66% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/plugins/reservation/utils.go 79.27% <100.00%> (ø)
pkg/scheduler/plugins/coscheduling/core/gang.go 74.44% <0.00%> (-0.95%) ⬇️
pkg/util/httputil/reverseproxy.go 84.84% <0.00%> (+0.53%) ⬆️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 67.05% <0.00%> (+5.29%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eahydra eahydra changed the title fix: reserve doesn't match pod when hostport is not set koord-scheduler: fix reservation doesn't match pod when hostport is not set Jan 3, 2023
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 42cab95 into koordinator-sh:main Jan 3, 2023
FillZpp pushed a commit that referenced this pull request Jan 16, 2023
…ot set (#916)

Signed-off-by: KunWuLuan <kunwuluan@gmail.com>
lucming pushed a commit to lucming/koordinator that referenced this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants