koord-scheduler: protect reserve pod from being preempted#920
Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom Jan 10, 2023
Conversation
Codecov ReportBase: 66.66% // Head: 66.48% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #920 +/- ##
==========================================
- Coverage 66.66% 66.48% -0.18%
==========================================
Files 240 241 +1
Lines 27769 27946 +177
==========================================
+ Hits 18513 18581 +68
- Misses 7987 8087 +100
- Partials 1269 1278 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
eahydra
changed the title
Member
|
@saintube PTAL |
eahydra
reviewed
Jan 4, 2023
KunWuLuan
force-pushed
the
protect-reserve-pod-from-being-preempted
branch
from
b4bbaa2 to
cad7c4b
Compare
saintube
reviewed
Jan 4, 2023
KunWuLuan
force-pushed
the
protect-reserve-pod-from-being-preempted
branch
6 times, most recently
from
624e647 to
4773d00
Compare
Signed-off-by: KunWuLuan <kunwuluan@gmail.com>
KunWuLuan
force-pushed
the
protect-reserve-pod-from-being-preempted
branch
from
4773d00 to
9e102fb
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
FillZpp
pushed a commit
that referenced
this pull request
Jan 16, 2023
Signed-off-by: KunWuLuan <kunwuluan@gmail.com>
lucming
pushed a commit
to lucming/koordinator
that referenced
this pull request
Feb 8, 2023
…r-sh#920) Signed-off-by: KunWuLuan <kunwuluan@gmail.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now reserve pod can be preempt by real pods, but these reserve pods won't be deleted by preemptor because they don't exist on apiserver. It will cause problem when a real pod try to preempt a reserve pod, the real pod will never find the reserve pod being terminated.