Skip to content

koordlet: fix cgroup validators#930

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
saintube:fix-cgroup-validator
Jan 5, 2023
Merged

koordlet: fix cgroup validators#930
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
saintube:fix-cgroup-validator

Conversation

@saintube
Copy link
Member

@saintube saintube commented Jan 5, 2023

Signed-off-by: saintube saintube@foxmail.com

Ⅰ. Describe what this PR does

fix the range validator for cgroup resources BlkioTRIopsName...

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: saintube <saintube@foxmail.com>
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Base: 66.46% // Head: 66.47% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (bd4ff8f) compared to base (a17a9cd).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #930      +/-   ##
==========================================
+ Coverage   66.46%   66.47%   +0.01%     
==========================================
  Files         241      241              
  Lines       27887    27887              
==========================================
+ Hits        18535    18539       +4     
+ Misses       8078     8074       -4     
  Partials     1274     1274              
Flag Coverage Δ
unittests 66.47% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/util/system/cgroup_resource.go 80.51% <ø> (ø)
pkg/util/httputil/reverseproxy.go 84.84% <0.00%> (+0.53%) ⬆️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 67.05% <0.00%> (+1.17%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zwzhang0107
Copy link
Contributor

/approve

@zwzhang0107
Copy link
Contributor

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasonliu747, zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jasonliu747
Copy link
Member

/lgtm

@koordinator-bot koordinator-bot bot merged commit e51758c into koordinator-sh:main Jan 5, 2023
FillZpp pushed a commit that referenced this pull request Jan 16, 2023
Signed-off-by: saintube <saintube@foxmail.com>
lucming pushed a commit to lucming/koordinator that referenced this pull request Feb 8, 2023
Signed-off-by: saintube <saintube@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants