Skip to content

runtimeproxy: fix env lost#957

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
lucming:fix_env_lost
Jan 27, 2023
Merged

runtimeproxy: fix env lost#957
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
lucming:fix_env_lost

Conversation

@lucming
Copy link
Contributor

@lucming lucming commented Jan 13, 2023

Ⅰ. Describe what this PR does

fix bug: env lost when container's env contains = in its value.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

kubectl apply -f nginx.yaml, like this

apiVersion: v1
kind: Pod
metadata:
  name: nginx
spec:
  containers:
    - name: nginx
      image: nginx
      env:
        - name: JAVA_OPT_EXT
          value: '-Ddubbo.consumer.check=false -Dmtd.account.cache.switch=off'

However, this env is not written in the container

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Base: 66.96% // Head: 66.99% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (d07083b) compared to base (388f7ad).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #957      +/-   ##
==========================================
+ Coverage   66.96%   66.99%   +0.03%     
==========================================
  Files         243      243              
  Lines       28240    28240              
==========================================
+ Hits        18910    18920      +10     
+ Misses       8035     8026       -9     
+ Partials     1295     1294       -1     
Flag Coverage Δ
unittests 66.99% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/runtimeproxy/server/docker/utils.go 87.11% <100.00%> (ø)
pkg/scheduler/plugins/coscheduling/core/gang.go 76.07% <0.00%> (+0.92%) ⬆️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 65.88% <0.00%> (+4.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: lucming <2876757716@qq.com>
@eahydra eahydra changed the title runtimeproxy:fix env lost runtimeproxy: fix env lost Jan 16, 2023
@honpey
Copy link
Contributor

honpey commented Jan 17, 2023

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit a5cbe35 into koordinator-sh:main Jan 27, 2023
@eahydra eahydra added this to the v1.2 milestone Jan 27, 2023
lucming added a commit to lucming/koordinator that referenced this pull request Feb 8, 2023
Signed-off-by: lucming <2876757716@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants