Skip to content

koordlet: fix not support cpu without L3 cache#960

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
shelwinnn:support-cpu-without-l3-cache
Jan 20, 2023
Merged

koordlet: fix not support cpu without L3 cache#960
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
shelwinnn:support-cpu-without-l3-cache

Conversation

@shelwinnn
Copy link
Contributor

Ⅰ. Describe what this PR does

Fix lscpu get cache info failed when the cpu has no L3 cache.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: shelwin <weixf@szhcf.com.cn>
@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Base: 66.96% // Head: 66.97% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (e13006e) compared to base (388f7ad).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head e13006e differs from pull request most recent head 71b0de7. Consider uploading reports for the commit 71b0de7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #960      +/-   ##
==========================================
+ Coverage   66.96%   66.97%   +0.01%     
==========================================
  Files         243      243              
  Lines       28240    28244       +4     
==========================================
+ Hits        18910    18917       +7     
+ Misses       8035     8032       -3     
  Partials     1295     1295              
Flag Coverage Δ
unittests 66.97% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/util/system/lscpu.go 0.00% <0.00%> (ø)
pkg/koordlet/runtimehooks/reconciler/reconciler.go 65.88% <0.00%> (+4.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shelwinnn shelwinnn force-pushed the support-cpu-without-l3-cache branch from e13006e to 71b0de7 Compare January 16, 2023 06:50
@saintube
Copy link
Member

saintube commented Jan 16, 2023

@shelwinnn It seems to be a compatibility problem. Could you please add more information about your system environment and what the lscpu's output (lscpu -e) is like?

@shelwinnn
Copy link
Contributor Author

@shelwinnn It seems to be a compatibility problem. Could you please add more information about your system environment and what the lscpu's output (lscpu -e) is like?

On my company's cloud, we use kvm as the cloud host and qemu-kvm not enable L3 cache, see: https://bugzilla.redhat.com/show_bug.cgi?id=1434537

lscpu -e=CPU,NODE,SOCKET,CORE,CACHE,ONLINE output:

CPU NODE SOCKET CORE L1d:L1i:L2    ONLINE
 0    0      0    0  0:0:0            yes
 1    0      0    1  1:1:1            yes
 2    0      0    2  2:2:2            yes
 3    0      0    3  3:3:3            yes
 4    0      1    4  4:4:4            yes
 5    0      1    5  5:5:5            yes
 6    0      1    6  6:6:6            yes
 7    0      1    7  7:7:7            yes

@saintube
Copy link
Member

saintube commented Jan 16, 2023

/lgtm
PTAL @jasonliu747 @zwzhang0107

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saintube

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 402e383 into koordinator-sh:main Jan 20, 2023
@eahydra eahydra added this to the v1.2 milestone Feb 7, 2023
lucming pushed a commit to lucming/koordinator that referenced this pull request Feb 8, 2023
Signed-off-by: shelwin <weixf@szhcf.com.cn>
Co-authored-by: shelwin <weixf@szhcf.com.cn>
@saintube saintube mentioned this pull request Dec 25, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants