Skip to content

koord-manager: revise slo-controllers, fix for deleted node#961

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
saintube:revise-slo-controller
Jan 16, 2023
Merged

koord-manager: revise slo-controllers, fix for deleted node#961
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
saintube:revise-slo-controller

Conversation

@saintube
Copy link
Member

Ⅰ. Describe what this PR does

revise the slo-controller and fix some bugs:

  1. fix the case when a node is deleted but nodeSLO or nodeMetric exists
  2. use a copy of the node when updating the node resources to avoid cache pollution

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: saintube <saintube@foxmail.com>
@saintube saintube force-pushed the revise-slo-controller branch from 16864ee to 9bb82db Compare January 16, 2023 09:21
@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Base: 66.96% // Head: 66.98% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (9bb82db) compared to base (388f7ad).
Patch coverage: 49.27% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #961      +/-   ##
==========================================
+ Coverage   66.96%   66.98%   +0.02%     
==========================================
  Files         243      243              
  Lines       28240    28245       +5     
==========================================
+ Hits        18910    18920      +10     
+ Misses       8035     8030       -5     
  Partials     1295     1295              
Flag Coverage Δ
unittests 66.98% <49.27%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...o-controller/config/colocation_cm_event_handler.go 75.86% <ø> (ø)
pkg/slo-controller/config/config.go 92.75% <ø> (ø)
pkg/slo-controller/nodeslo/nodeslo_controller.go 46.45% <4.76%> (ø)
...slo-controller/nodemetric/nodemetric_controller.go 51.85% <12.50%> (-0.49%) ⬇️
...controller/noderesource/noderesource_controller.go 36.47% <55.55%> (-0.88%) ⬇️
pkg/slo-controller/noderesource/noderesource.go 76.17% <85.18%> (-0.23%) ⬇️
...ontroller/noderesource/nodemetric_event_handler.go 90.90% <100.00%> (ø)
pkg/koordlet/runtimehooks/reconciler/reconciler.go 67.05% <0.00%> (+5.29%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zwzhang0107
Copy link
Contributor

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit a8c3352 into koordinator-sh:main Jan 16, 2023
@eahydra eahydra added this to the v1.2 milestone Feb 7, 2023
lucming pushed a commit to lucming/koordinator that referenced this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants