Skip to content

clean: resolve vet error#970

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
eahydra:clean_deviceshare_vet_error
Jan 31, 2023
Merged

clean: resolve vet error#970
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
eahydra:clean_deviceshare_vet_error

Conversation

@eahydra
Copy link
Member

@eahydra eahydra commented Jan 31, 2023

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Base: 66.97% // Head: 66.96% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (4a0244e) compared to base (79ce5e0).
Patch coverage: 86.53% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #970      +/-   ##
==========================================
- Coverage   66.97%   66.96%   -0.02%     
==========================================
  Files         243      244       +1     
  Lines       28287    28318      +31     
==========================================
+ Hits        18946    18963      +17     
- Misses       8043     8054      +11     
- Partials     1298     1301       +3     
Flag Coverage Δ
unittests 66.96% <86.53%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/plugins/deviceshare/pod_handler.go 88.05% <75.00%> (-7.13%) ⬇️
pkg/scheduler/plugins/deviceshare/plugin.go 87.71% <81.25%> (-1.11%) ⬇️
pkg/scheduler/plugins/deviceshare/allocator.go 87.50% <87.50%> (ø)
pkg/scheduler/plugins/deviceshare/device_cache.go 86.18% <93.18%> (-0.04%) ⬇️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 65.88% <0.00%> (-1.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@koordinator-bot koordinator-bot bot merged commit 691bddd into koordinator-sh:main Jan 31, 2023
lucming pushed a commit to lucming/koordinator that referenced this pull request Feb 8, 2023
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants