Skip to content

koord-descheduler: fix LowNodeLoad when configuring nodeSelector#975

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
eahydra:fix_lownodeload_error
Feb 2, 2023
Merged

koord-descheduler: fix LowNodeLoad when configuring nodeSelector#975
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
eahydra:fix_lownodeload_error

Conversation

@eahydra
Copy link
Member

@eahydra eahydra commented Feb 1, 2023

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Base: 66.97% // Head: 66.99% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (0ad2669) compared to base (691bddd).
Patch coverage: 20.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #975      +/-   ##
==========================================
+ Coverage   66.97%   66.99%   +0.01%     
==========================================
  Files         244      244              
  Lines       28318    28322       +4     
==========================================
+ Hits        18966    18973       +7     
+ Misses       8052     8047       -5     
- Partials     1300     1302       +2     
Flag Coverage Δ
unittests 66.99% <20.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...duler/framework/plugins/loadaware/low_node_load.go 70.58% <20.00%> (+3.58%) ⬆️
pkg/scheduler/plugins/coscheduling/core/gang.go 75.15% <0.00%> (-0.93%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra force-pushed the fix_lownodeload_error branch from a1353c2 to 0ad2669 Compare February 1, 2023 12:09
@koordinator-bot koordinator-bot bot added size/M and removed size/XS labels Feb 1, 2023
@zwzhang0107
Copy link
Contributor

/lgtm

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 7c28cdd into koordinator-sh:main Feb 2, 2023
@eahydra eahydra added this to the v1.2 milestone Feb 7, 2023
lucming pushed a commit to lucming/koordinator that referenced this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants