Skip to content

koordlet: remove deprecated executor package#986

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
novahe:remove-executor-pkg
Feb 6, 2023
Merged

koordlet: remove deprecated executor package#986
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
novahe:remove-executor-pkg

Conversation

@novahe
Copy link
Contributor

@novahe novahe commented Feb 5, 2023

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fix: #971

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: novahe <heqianfly@gmail.com>
@novahe novahe force-pushed the remove-executor-pkg branch from 041d7f8 to 1c002de Compare February 5, 2023 08:11
@codecov
Copy link

codecov bot commented Feb 5, 2023

Codecov Report

Base: 66.99% // Head: 67.47% // Increases project coverage by +0.47% 🎉

Coverage data is based on head (1c002de) compared to base (1e3fa53).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #986      +/-   ##
==========================================
+ Coverage   66.99%   67.47%   +0.47%     
==========================================
  Files         244      241       -3     
  Lines       28330    27988     -342     
==========================================
- Hits        18981    18886      -95     
+ Misses       8049     7801     -248     
- Partials     1300     1301       +1     
Flag Coverage Δ
unittests 67.47% <ø> (+0.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/plugins/coscheduling/core/gang.go 75.15% <0.00%> (-0.93%) ⬇️
pkg/util/httputil/reverseproxy.go 85.10% <0.00%> (+0.26%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jasonliu747 jasonliu747 changed the title remove deprecated executor package koordlet: remove deprecated executor package Feb 6, 2023
@saintube
Copy link
Member

saintube commented Feb 6, 2023

/cc @Re-Grh

@koordinator-bot
Copy link

@saintube: GitHub didn't allow me to request PR reviews from the following users: Re-Grh.

Note that only koordinator-sh members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @Re-Grh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Re-Grh
Copy link
Contributor

Re-Grh commented Feb 6, 2023

/lgtm

@koordinator-bot
Copy link

@Re-Grh: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saintube
Copy link
Member

saintube commented Feb 6, 2023

/lgtm

@hormes
Copy link
Member

hormes commented Feb 6, 2023

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 02a98d4 into koordinator-sh:main Feb 6, 2023
@novahe novahe deleted the remove-executor-pkg branch February 6, 2023 16:32
@eahydra eahydra added this to the v1.2 milestone Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[proposal] Remove deprecated executor package

5 participants