Adding the possibility to add an array of other layers to compare.#4
Open
kent1D wants to merge 2 commits intokosmtik:masterfrom
Open
Adding the possibility to add an array of other layers to compare.#4kent1D wants to merge 2 commits intokosmtik:masterfrom
kent1D wants to merge 2 commits intokosmtik:masterfrom
Conversation
Adding the possibility to add an array of other layers to compare. The option is `compareUrls`, maybe should be renamed.
Member
yohanboniface
left a comment
yohanboniface
left a comment
There was a problem hiding this comment.
Sounds good :)
One suggestion: instead of having a new option, maybe just check the type of the value, and accept either a string or an array of strings.
Also a quick note on the README would be cool :)
* a string (just the URL to a layer) * a simple Array (Url => Name) * an Array of Arrays (Url => Name)
Author
|
We accept a string (just the Url), a simple Array [URL, Name], an array of Arrays |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix kosmtik/kosmtik#279
The option is
compareUrls, maybe should be renamed.