Skip to content

[#186] Implement TOML difference#363

Merged
chshersh merged 1 commit intomainfrom
vrom911/186-Implement-TOML-difference
Feb 12, 2021
Merged

[#186] Implement TOML difference#363
chshersh merged 1 commit intomainfrom
vrom911/186-Implement-TOML-difference

Conversation

@vrom911
Copy link
Copy Markdown
Member

@vrom911 vrom911 commented Feb 12, 2021

Resolves #186

Shout out to @chshersh for pair programming 🙌🏼 ❤️

@vrom911 vrom911 requested a review from chshersh as a code owner February 12, 2021 17:33
@vrom911 vrom911 self-assigned this Feb 12, 2021
@vrom911 vrom911 added the λ-safe Type safety, validation label Feb 12, 2021
Copy link
Copy Markdown
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! It was a pleasure working on this together 🤗

Looking forward to using this function!


@since x.x.x.x
-}
differenceWithT :: (a -> b -> Maybe a) -> PrefixTree a -> PrefixTree b -> Maybe (PrefixTree a)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a tough function to implement 😰

@chshersh chshersh merged commit d655873 into main Feb 12, 2021
@chshersh chshersh deleted the vrom911/186-Implement-TOML-difference branch February 12, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

λ-safe Type safety, validation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement TOML difference

2 participants