Allow Doom-in-Hexen format maps to use Lightning #801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Needs work / review - No LightningSound at the moment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this is a very very early draft...
Need y'all to look into this. Technically this does work, but we may wanna structure this better.
Requires Doom-in-Hexen map format and MAPINFO with the line "Lightning".
Here's a very basic demo map: lightning-doom-test-map.wad
Currently the lightning seems to work, but it's currently using
pr_hexenfor randomness (not sure if this is good or not).Also note that I've disabled the sound currently for Doom.. Not sure how we are gonna deal with that, since currently DSDA only allows sounds in the
sfxenum_tlist.There is a MAPINFO field called "LightningSound" but it probably uses names from a lump like SNDINFO. ZDoom tends to use "World/Thunder" as the default value. I just don't think DSDA is currently setup for this functionality quite yet.