Update console.c

[Akhileshgf]

Added, target.get_target_index command to know their mobj index

[rfomin]

We don't need the dsda_GetMobjIndex function; you can simply write int id = target ? target->index : -1.
What about closing #809 and simplifying this?

[Akhileshgf]

Sure, I wasn't able to get mobj index in the casual way which was required for certain console commands. I wanted to get it badly. I know python but not C. That's why I tried to understand the console code with the help of a copilot and it also proposed a solution to the problem. Copilot suggested this function. It seems like the function itself was not fully accurate because C_Printf was not supported. We can close this, sorry for bothering you. DSDA doom is my favorite source port.

…

On Sat, Nov 22, 2025 at 1:42 PM Roman Fomin ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In prboom2/src/dsda/console.c <#810 (comment)>: > @@ -1316,6 +1316,19 @@ static void console_SetMobjFlags(mobj_t* mobj, uint64_t flags, uint64_t flags2) P_MapEnd(); } +static dboolean console_GetTargetID(const char* command, const char* args) { + mobj_t* target = HU_Target(); // current HUD target + int id = dsda_GetMobjIndex(target); We don't need the dsda_GetMobjIndex function; you can simply write int id = target ? target->index : -1. What about closing #809 <#809> and simplifying this? — Reply to this email directly, view it on GitHub <#810 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BUSBHJBT6ICPI3KK6FW4CRD36ALILAVCNFSM6AAAAACM2UYVYSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTIOJWGEYDKOBTHE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[Akhileshgf]

static dboolean console_GetTargetID(const char* command, const char* args) { mobj_t* target = HU_Target(); // current HUD target int id = target ? target->index : -1; dsda_string_t str; if (target) { dsda_StringPrintF(&str, "Mobj_index : %d", id); } else { dsda_StringPrintF(&str, "No valid target selected."); } dsda_AddAlert(str.string); dsda_FreeString(&str); return true; } This is working code in case you want. On Sat, Nov 22, 2025 at 2:14 PM Akhilesh Deodhar ***@***.***> wrote:

…

Sure, I wasn't able to get mobj index in the casual way which was required for certain console commands. I wanted to get it badly. I know python but not C. That's why I tried to understand the console code with the help of a copilot and it also proposed a solution to the problem. Copilot suggested this function. It seems like the function itself was not fully accurate because C_Printf was not supported. We can close this, sorry for bothering you. DSDA doom is my favorite source port. On Sat, Nov 22, 2025 at 1:42 PM Roman Fomin ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In prboom2/src/dsda/console.c > <#810 (comment)>: > > > @@ -1316,6 +1316,19 @@ static void console_SetMobjFlags(mobj_t* mobj, uint64_t flags, uint64_t flags2) > P_MapEnd(); > } > > +static dboolean console_GetTargetID(const char* command, const char* args) { > + mobj_t* target = HU_Target(); // current HUD target > + int id = dsda_GetMobjIndex(target); > > We don't need the dsda_GetMobjIndex function; you can simply write int > id = target ? target->index : -1. > What about closing #809 <#809> > and simplifying this? > > — > Reply to this email directly, view it on GitHub > <#810 (review)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/BUSBHJBT6ICPI3KK6FW4CRD36ALILAVCNFSM6AAAAACM2UYVYSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTIOJWGEYDKOBTHE> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> >