Skip to content

Shorten leptos build_data to more idiomatic Rust #1933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Shorten leptos build_data to more idiomatic Rust #1933

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
86bc65c
Shorten build_data to more idiomatic Rust
daniel-pfeiffer Oct 12, 2025
46f2221
map strs as well
daniel-pfeiffer Oct 12, 2025
678440b
more readable
daniel-pfeiffer Oct 12, 2025
5a0b952
Almost eliminate atomics
daniel-pfeiffer Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 12 additions & 24 deletions frameworks/keyed/leptos/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,30 +50,18 @@ static ID_COUNTER: AtomicUsize = AtomicUsize::new(1);
fn build_data(count: usize) -> Vec<RowData> {
let mut thread_rng = thread_rng();

let mut data = Vec::new();
data.reserve_exact(count);

for _i in 0..count {
let adjective = ADJECTIVES.choose(&mut thread_rng).unwrap();
let colour = COLOURS.choose(&mut thread_rng).unwrap();
let noun = NOUNS.choose(&mut thread_rng).unwrap();
let capacity = adjective.len() + colour.len() + noun.len() + 2;
let mut label = String::with_capacity(capacity);
label.push_str(adjective);
label.push(' ');
label.push_str(colour);
label.push(' ');
label.push_str(noun);

data.push(RowData {
id: ID_COUNTER.load(Ordering::Relaxed),
label: ArcRwSignal::new(label),
});

ID_COUNTER.store(ID_COUNTER.load(Ordering::Relaxed) + 1, Ordering::Relaxed);
}

data
let mut label = || [ADJECTIVES, COLOURS, NOUNS]
.map(|slice| slice.choose(&mut thread_rng).unwrap())
.join(" ");

let id = ID_COUNTER.fetch_add(count, Ordering::Relaxed);

(id..id + count)
.map(|id| RowData {
id,
label: ArcRwSignal::new(label())
})
.collect()
}

/// Button component.
Expand Down