Update pota #1934
Open
Update pota #1934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, a small update,
@staticdoesn't callgetValueso this should remove some useless function callsRandom thing I have noticed, pota shows first than Inferno, both have a geometric mean of
1.10. But Inferno is like 3ms~ faster. I understand this is kind of meaningless, but would be nice that after sorting by geometric mean it could also sort by the sum of time taken, that way the result of similar frameworks could possibly be more steady. But honestly not sure, because if the variation swings, then its kinda pointless. Just an ideaThanks!