update lui, adding noeval variant #1935
Open
+696
−96
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not improve much but just updated to the latest lui version.
And to make the result slightly smaller, added minification. I minify with bun but in case you don't like my approach, just use some other simple minifier.
And to remove the CSP issue, added a non-eval variant.
Very surprisingly, it performs almost the same on my machine, throwing me into an existential crysis.
There must be some advanced pattern matching in v8 detecting object key iteration and transforming it into struct lookups.
I wonder how Firefox and Safari would perform.
Maybe in future, I will make the noeval variant default and remove the other benchmark.
Thanks.