Conversation
Agent-Logs-Url: https://github.com/kreuzwerker/terraform-provider-docker/sessions/edc1a8fc-8b53-422d-aaf0-0ec04314dec4 Co-authored-by: Junkern <3775779+Junkern@users.noreply.github.com>
Agent-Logs-Url: https://github.com/kreuzwerker/terraform-provider-docker/sessions/edc1a8fc-8b53-422d-aaf0-0ec04314dec4 Co-authored-by: Junkern <3775779+Junkern@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix drift in docker_service rollback_config.max_failure_ratio
Normalize Apr 11, 2026
docker_service max_failure_ratio diffs to prevent 0 vs 0.0 drift
mx-moth
added a commit
to mx-moth/terraform-provider-docker
that referenced
this pull request
Apr 13, 2026
…to-service * upstream/master: chore: Replace git-chglog with git-cliff (kreuzwerker#904) feat: Implement docker registry image tags data source (kreuzwerker#903) Fix flaky `docker_container` destroy by disabling link removal during delete (kreuzwerker#902) Normalize `docker_service` `max_failure_ratio` diffs to prevent `0` vs `0.0` drift (kreuzwerker#901) Fix `docker_container.container_logs` to return demultiplexed log content (kreuzwerker#899) feat: Add docker import action (kreuzwerker#900) docs: add missing docker_exec/buildx examples and align action name to docker_exec (kreuzwerker#898) feat: Expose attached container network addresses in `docker_network` data source (kreuzwerker#897) chore: Prepare release 4.1.0 (kreuzwerker#896) Prevent `docker_container` read panic with CDI `device_requests` by hardening device flattening (kreuzwerker#895) Add Plugin Framework `docker_containers` data source for Docker container enumeration (kreuzwerker#893) Fix `docker_service` platform flattening hash to prevent platform list drift on updates (kreuzwerker#892) fix: Make container deletion idempotent for missing containers (kreuzwerker#891) fix(deps): update module github.com/containerd/platforms to v1.0.0-rc.4 (kreuzwerker#889) Avoid `docker_container` replacement when only daemon default `log_opts` are present (kreuzwerker#888) Add `platform` support to `docker_container` for cross-architecture emulation (kreuzwerker#886) Allow `docker_registry_image.auth_config` to mirror provider `registry_auth` optional credentials (kreuzwerker#887) feat: Implement docker_exec action (kreuzwerker#885) chore: Prepare 4.0.0 release (kreuzwerker#884) feat: add selinux_relabel attribute to docker_container volumes (kreuzwerker#883)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker_servicewas planning perpetual in-place updates whenrollback_config.max_failure_ratio(and similarlyupdate_config.max_failure_ratio) differed only by string formatting ("0"vs"0.0"). The provider state/read path formats this value as a decimal string, which caused Terraform to detect non-semantic drift.Schema diff normalization for ratio fields
suppressEquivalentFloatRatio) that parses old/new values as floats and suppresses diffs when numerically equal.update_config.max_failure_ratiorollback_config.max_failure_ratioTargeted unit coverage for drift semantics