fix php codegen #93
Merged
fix php codegen #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbreton
approved these changes
Nov 30, 2021
Chris-V
approved these changes
Nov 30, 2021
There was a problem hiding this comment.
Est-ce que le plan est:
- Contribuer le support du oneOf upstream au repo de openapi?
- Remplacer le yaml généré par micronaut pour nous sortir
nullable: true+ allOf avec un seul élément? Pour ce cas-ci, est-ce que ton patch sur le générateur Micronaut fonctionne quand même? Je crois qu'il ne validatait que leoneOf.
C'est contribué upstream depuis un bout. J'ai un approve mais c'est pas merged. OpenAPITools/openapi-generator#10602 je supporte juste oneOf avec nullable ou null, jamais allOf |
|
Alright, dans ce cas j'irai ajuster mon fix sur micronaut-openapi pour générer oneOf quand on a nullable + 1 seul élément |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
les champs nullable sans oneOf plante
J'ai aussi updaté la pr upstream