Run tests with multiple php and mysql versions #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgrabenstein
force-pushed
the
feature/matrix-testing
branch
from
67b8e97 to
4e6462c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically a continuation of #121.
The old pipeline was always running with mysql 8.0 because the tests were connecting to
mysqlrunning in the ubunut host, and not themysqlrunning in the docker container.Since I could not find a way how to set up the mysql container with a custom config (needed to enable the binlog), I used this mysql setup action which offers the possibility to set up custom config values.
Furthermore I had to adapt the query checking if the binlog was enabled if running with mysql 8.4 because
SHOW MASTER STATSis no longer supported. A good way to confirm that the tests are actually running with the specified mysql versions.