chore: Preserve command history from make develop sessions
#234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ModelMesh develop container runs as root and needs the command history file mounted under the /root/ directory, not /workspace/ Signed-off-by: Christian Kadner <[email protected]>
|
/retest |
ckadner
changed the title
make develop sessions
chinhuang007
reviewed
Sep 9, 2022
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chinhuang007, ckadner The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks @chinhuang007 for your review! |
ckadner
changed the title
make develop sessionsmake develop sessions
|
Merging since lgtm bot didn't do it for some reason. |
Thanks @njhill -- the |
hdefazio
pushed a commit
to hdefazio/modelmesh-serving
that referenced
this pull request
Jul 1, 2025
Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com> Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When using the containerized development environment (
make develop) to test changes to the ModelMesh source code or running FVT tests all command history is lost from session to session -- which negatively impacts productivity.Modifications
The ModelMesh develop container runs as root and needs the command history file mounted under the
/root/directory, not/workspace/Result
The develop container command history is preserved from one
make developsession to the next./cc @njhill @chinhuang007