Enhancement: in REPL mode allow user to specify path to file for bytes field #280
Conversation
Codecov Report
@@ Coverage Diff @@
## master #280 +/- ##
==========================================
- Coverage 82.57% 82.47% -0.10%
==========================================
Files 57 57
Lines 3139 3156 +17
==========================================
+ Hits 2592 2603 +11
- Misses 313 316 +3
- Partials 234 237 +3 |
|
the build is failed because of the additional \r byte in windows files. |
BenSlabbert
force-pushed
the
enhancement/read-file-in-repl
branch
from
e9e25bb to
d6b5032
Compare
| @@ -1,16 +1,86 @@ | |||
| package proto_test | |||
| package proto | |||
There was a problem hiding this comment.
I dropped the _test because I needed access to the internal function I wanted to test.
ktr0731
left a comment
ktr0731
left a comment
There was a problem hiding this comment.
Sorry for the delay in replying.
It's almost perfect! I have only pointed out a few minor points.
fill/proto/interactive_filler.go
Outdated
| default: // Normal fields. | ||
| f.prompt.SetPrefix(f.makePrefix(field)) | ||
| v, err := f.inputPrimitiveField(field) | ||
| v, err := f.inputPrimitiveField(descriptor.FieldDescriptorProto_Type(descriptor.FieldDescriptorProto_Type_value[field.GetType().String()])) |
There was a problem hiding this comment.
| v, err := f.inputPrimitiveField(descriptor.FieldDescriptorProto_Type(descriptor.FieldDescriptorProto_Type_value[field.GetType().String()])) | |
| v, err := f.inputPrimitiveField(field.GetType()) |
fill/proto/interactive_filler.go
Outdated
| absPath, err := filepath.Abs(path) | ||
| if err != nil { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
These lines are unnecessary because ioutil.ReadFile also accepts relative paths.
There was a problem hiding this comment.
didn't know that :)
| // inputPrimitiveField reads an input and converts it to a Go type. | ||
| // If CTRL+d is entered, inputPrimitiveField returns io.EOF. | ||
| func (f *InteractiveFiller) inputPrimitiveField(field *desc.FieldDescriptor) (interface{}, error) { | ||
| func (f *InteractiveFiller) inputPrimitiveField(fieldType descriptor.FieldDescriptorProto_Type) (interface{}, error) { |
| type testPrompt struct { | ||
| input string | ||
| } |
There was a problem hiding this comment.
Can you embed prompt.Prompt and remove methods other than Input?
| type testPrompt struct { | |
| input string | |
| } | |
| type testPrompt struct { | |
| prompt.Prompt | |
| input string | |
| } |
There was a problem hiding this comment.
great suggestion thank you!
ktr0731
left a comment
ktr0731
left a comment
There was a problem hiding this comment.
LGTM 👍
Thanks for your contribution!
2 participants
see Issue: #279