Skip to content

Define testing objects in separate files #121

@kimwnasptd

Description

@kimwnasptd

Checks

Motivation

Right now some tests files are applying YAML objects (i.e. PodDefaults, Profiles) which are read as inline commands directly in GitHub actions.

This makes the logic in the actions more involved to follow, and we can end up with duplicated code.

An example of this is

- name: Create Test Profile for Dashboard Testing
run: |
cat <<EOF | kubectl apply -f -
apiVersion: kubeflow.org/v1
kind: Profile
metadata:
name: test-dashboard-profile
spec:
owner:
kind: User
name: dashboard-user@example.com
EOF

While we already have defined a profile in https://github.com/kubeflow/dashboard/blob/8ce75658d1563de2a29b65e77afcf36050cd925c/testing/gh-actions/resources/user-profile.yaml

Implementation

The suggestion here is to always commit the YAML files that might be needed for tests. Some nice (IMO) cases of this are:

  1. kind-1-33.yaml
  2. items in the resources folder

Are you willing & able to help?

  • I am able to submit a PR!
  • I can help test the feature!

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions