Checks
Motivation
Right now some tests files are applying YAML objects (i.e. PodDefaults, Profiles) which are read as inline commands directly in GitHub actions.
This makes the logic in the actions more involved to follow, and we can end up with duplicated code.
An example of this is
|
- name: Create Test Profile for Dashboard Testing |
|
run: | |
|
cat <<EOF | kubectl apply -f - |
|
apiVersion: kubeflow.org/v1 |
|
kind: Profile |
|
metadata: |
|
name: test-dashboard-profile |
|
spec: |
|
owner: |
|
kind: User |
|
name: dashboard-user@example.com |
|
EOF |
While we already have defined a profile in https://github.com/kubeflow/dashboard/blob/8ce75658d1563de2a29b65e77afcf36050cd925c/testing/gh-actions/resources/user-profile.yaml
Implementation
The suggestion here is to always commit the YAML files that might be needed for tests. Some nice (IMO) cases of this are:
- kind-1-33.yaml
- items in the resources folder
Are you willing & able to help?
Checks
kubeflow/dashboardrepository.Motivation
Right now some tests files are applying YAML objects (i.e. PodDefaults, Profiles) which are read as inline commands directly in GitHub actions.
This makes the logic in the actions more involved to follow, and we can end up with duplicated code.
An example of this is
dashboard/.github/workflows/central_dashboard_integration_test.yaml
Lines 71 to 82 in 8ce7565
While we already have defined a profile in https://github.com/kubeflow/dashboard/blob/8ce75658d1563de2a29b65e77afcf36050cd925c/testing/gh-actions/resources/user-profile.yaml
Implementation
The suggestion here is to always commit the YAML files that might be needed for tests. Some nice (IMO) cases of this are:
Are you willing & able to help?