refactor: profile-controller manifests similar to notebooks v2

[alokdangre]

Summary

Refactor profile-controller manifests to match the notebooks-style manifests/kustomize layout and keep Istio resources as a reusable component.

• Move all manifests from config/ to manifests/kustomize/.
• Restructure top-level folders to strict format:
  • base/
  • components/
  • overlays/
  • samples/
• Keep Istio manifests as reusable component:
  • components/istio/{authorizationpolicy,virtual-service,params,kustomization}.yaml
• Update overlays/kubeflow/kustomization.yaml to compose Istio via:
  • components: ../../components/istio
  • while keeping overlay-specific service.yaml and patches/.
• Consolidate base composition in base/kustomization.yaml and nest generated resources under:
  • base/crd/
  • base/manager/
  • base/rbac/
  • base/patches/
• Update path consumers to new manifest location:
  • components/profile-controller/Makefile
  • testing/shared/install_profile_controller.sh
  • releasing/update-manifests-images.py
• Standardize common labels in:
  • manifests/kustomize/base/kustomization.yaml
  • manifests/kustomize/overlays/kubeflow/kustomization.yaml
  • manifests/kustomize/overlays/standalone/kustomization.yaml
• Keep AuthorizationPolicy selector aligned to app: profiles.

related: #180

Directory Structure

manifests/
└── kustomize/
    ├── base/
    │   ├── crd/
    │   ├── manager/
    │   ├── patches/
    │   ├── rbac/
    │   ├── kustomization.yaml
    │   └── namespace-labels.yaml
    ├── components/
    │   ├── istio/
    │   │   ├── authorizationpolicy.yaml
    │   │   ├── kustomization.yaml
    │   │   ├── params.yaml
    │   │   └── virtual-service.yaml
    │   └── prometheus/
    ├── overlays/
    │   ├── kubeflow/
    │   │   ├── kustomization.yaml
    │   │   ├── patches/
    │   │   └── service.yaml
    │   └── standalone/
    ├── samples/
    └── README.md

Note: kustomize deprecation warnings (commonLabels, patchesStrategicMerge, vars) are pre-existing and not introduced by this refactor.

[alokdangre]

• Moved generated dirs under base:
  • crd -> base/crd
  • manager -> base/manager
  • rbac -> base/rbac
  • Moved old default patches into base/patches and merged base/default behavior into kustomization.yaml
  • Moved prometheus resources into components/prometheus.
• Updated path consumers:
  • components/profile-controller/Makefile
  • install_profile_controller.sh
  • update-manifests-images.py
• Updated docs/comments for new structure:
  • README.md
  • kustomization.yaml

[andyatmiami]

@alokdangre

Most importantly - I appreciate your willingness to learn and jump in on this admittedly complex refactoring of profile-controller. I'm sure you and I both will learn a lot as we get this PR in shape to be merge-able.

That being said - we have a lot of work we need to do to get this PR ready 😇

I would highly encourage you to make the folder hierarchy AS SIMILAR AS POSSIBLE to what the controller directory looks like in notebooks-v2:

• https://github.com/kubeflow/notebooks/tree/3449d0eaf41d4b77fa2243413a99bd7fa99c74d6/workspaces/controller/manifests/kustomize

⚠️ There will be certainly some differences with profile-controller as compared to notebooks-v2/controller - as profile-controller acts like both the backend and controller of notebooks-v2 as a single thing. Additionally, the kfam logic in this repo is also wild and not a pattern you will find in notebooks-v2 😎

ℹ️ I'm sure there is going to be a couple rounds of reviews necessary to get this ready to roll. As such - please understand all the PR comments contained herein are NOT exhaustive. Lets focus first on fixing, above all else, the directory structure. As other things clean up - I can then focus more on the content of the files - which I didn't have enough focus time to do on this PR.

[alokdangre]

@alokdangre

Most importantly - I appreciate your willingness to learn and jump in on this admittedly complex refactoring of profile-controller. I'm sure you and I both will learn a lot as we get this PR in shape to be merge-able.

That being said - we have a lot of work we need to do to get this PR ready 😇

I would highly encourage you to make the folder hierarchy AS SIMILAR AS POSSIBLE to what the controller directory looks like in notebooks-v2:

• https://github.com/kubeflow/notebooks/tree/3449d0eaf41d4b77fa2243413a99bd7fa99c74d6/workspaces/controller/manifests/kustomize

⚠️ There will be certainly some differences with profile-controller as compared to notebooks-v2/controller - as profile-controller acts like both the backend and controller of notebooks-v2 as a single thing. Additionally, the kfam logic in this repo is also wild and not a pattern you will find in notebooks-v2 😎

ℹ️ I'm sure there is going to be a couple rounds of reviews necessary to get this ready to roll. As such - please understand all the PR comments contained herein are NOT exhaustive. Lets focus first on fixing, above all else, the directory structure. As other things clean up - I can then focus more on the content of the files - which I didn't have enough focus time to do on this PR.

@andyatmiami thanks fo reviewing, i now understand and implemented the folder structure as per notebooks v2

[thesuperzapper]

/ok-to-test

[thesuperzapper]

Thanks to everyone for working to get this over the line, especially @andyatmiami and @alokdangre for doing extended live coding sessions to figure a lot of this legacy stuff out.

I have been pushing commits as we were working, and am now happy to merge this, especially as all tests now pass, and because we will be doing more testing before we cut a final 2.0.0 release anyway, hopefully we come across anything we missed during that process.

But thanks again as this series of PRs has left the dashboard manifests in a much more maintainable state for future releases!

/lgtm
/approve

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [thesuperzapper]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment