fix: upgrade VirtualService manifests from v1alpha3 to v1#219
fix: upgrade VirtualService manifests from v1alpha3 to v1#219KUNDAN1334 wants to merge 1 commit intokubeflow:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ac6390c to
2be0d38
Compare
Signed-off-by: KUNDAN1334 <kundan.22bcon1334@jecrcu.edu.in>
|
There already is a patch for this pending, see #201, in the context of this PR it was discovered that we also need to fix a few things in the test environment to make this happen 🤔 |
|
@christian-heusel VirtualService v1 upgrade working perfectly! Applied successfully in all tests: Test failures expected (no Istio in Kind cluster): no matches for kind "VirtualService" in version "networking.istio.io/v1" Ready to close once comprehensive patch lands. Thanks for |
|
This pull request has been automatically marked as stale because it has not had recent activity. Members may comment |
Description
Upgrades VirtualService API version from the deprecated
networking.istio.io/v1alpha3to stablenetworking.istio.io/v1across all dashboard manifests.Changes:
components/centraldashboard/manifests/kustomize/components/istio/virtual-service.yamlcomponents/centraldashboard-angular/manifests/kustomize/components/istio/virtual-service.yamlcomponents/profile-controller/config/overlays/kubeflow/virtual-service.yamlNo spec changes required - v1 API is backward compatible with existing VirtualService configurations.
Related Issue
Closes #201
Verification
apiVersion: networking.istio.io/v1