Skip to content

fix: upgrade VirtualService manifests from v1alpha3 to v1#219

Open
KUNDAN1334 wants to merge 1 commit intokubeflow:mainfrom
KUNDAN1334:Upgrade_VirtualService_manifests
Open

fix: upgrade VirtualService manifests from v1alpha3 to v1#219
KUNDAN1334 wants to merge 1 commit intokubeflow:mainfrom
KUNDAN1334:Upgrade_VirtualService_manifests

Conversation

@KUNDAN1334
Copy link
Copy Markdown

Description

Upgrades VirtualService API version from the deprecated networking.istio.io/v1alpha3 to stable networking.istio.io/v1 across all dashboard manifests.

Changes:

  • components/centraldashboard/manifests/kustomize/components/istio/virtual-service.yaml
  • components/centraldashboard-angular/manifests/kustomize/components/istio/virtual-service.yaml
  • components/profile-controller/config/overlays/kubeflow/virtual-service.yaml

No spec changes required - v1 API is backward compatible with existing VirtualService configurations.

Related Issue

Closes #201

Verification

  • All 3 files updated with correct apiVersion: networking.istio.io/v1
  • YAML syntax preserved
  • No functional changes to routing/gateway configuration

@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign thesuperzapper for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot added the area/dashboard area - related to central dashboard label Feb 21, 2026
@google-oss-prow google-oss-prow Bot added area/dashboard-angular area - related to central dashboard angular area/profiles area - related to profile-controller size/XS labels Feb 21, 2026
@KUNDAN1334 KUNDAN1334 force-pushed the Upgrade_VirtualService_manifests branch from ac6390c to 2be0d38 Compare February 21, 2026 21:23
Signed-off-by: KUNDAN1334 <kundan.22bcon1334@jecrcu.edu.in>
@KUNDAN1334 KUNDAN1334 changed the title fix(istio): upgrade VirtualService manifests from v1alpha3 to v1 fix: upgrade VirtualService manifests from v1alpha3 to v1 Feb 21, 2026
@christian-heusel
Copy link
Copy Markdown
Contributor

There already is a patch for this pending, see #201, in the context of this PR it was discovered that we also need to fix a few things in the test environment to make this happen 🤔
/ok-to-test

@KUNDAN1334
Copy link
Copy Markdown
Author

KUNDAN1334 commented Feb 21, 2026

@christian-heusel VirtualService v1 upgrade working perfectly!

Applied successfully in all tests:
centraldashboard/.../virtual-service.yaml → networking.istio.io/v1
centraldashboard-angular/.../virtual-service.yaml → networking.istio.io/v1
profile-controller/.../virtual-service.yaml → networking.istio.io/v1

Test failures expected (no Istio in Kind cluster):

no matches for kind "VirtualService" in version "networking.istio.io/v1"

Ready to close once comprehensive patch lands. Thanks for /ok-to-test!

@github-actions
Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed if no further activity occurs.
Thank you for your contributions.

Members may comment /lifecycle frozen to prevent this pull request from being marked as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dashboard area - related to central dashboard area/dashboard-angular area - related to central dashboard angular area/profiles area - related to profile-controller lifecycle/stale ok-to-test size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade VirtualService manifests from v1alpha3 to stable networking.istio.io/v1

2 participants