feat: add ambient mode support#267
Open
dariofaccin wants to merge 2 commits intokubeflow:mainfrom
Open
Conversation
google-oss-prow
Bot
added
area/dashboard
dariofaccin
force-pushed
the
feat/ambient-mode
branch
from
554c1f8 to
9580ff9
Compare
Member
|
Please do a proper rebase to master, I see old merged commits from other people. |
Signed-off-by: madmecodes <ayushguptadev1@gmail.com> Signed-off-by: Kimonas Sotirchos <kimonas.sotirchos@canonical.com>
Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>
dariofaccin
force-pushed
the
feat/ambient-mode
branch
from
9580ff9 to
5a878ec
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Author
|
Hi @juliusvonkohout, the PR is rebased on current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the clone of #185.
The PR by Kimonas was rebased (and conflicts fixed) on top of
v2.0-branch.cc @deusebio