Skip to content

chore: Update image for metacontroller #11474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

biswassri
Copy link
Contributor

@biswassri biswassri commented Dec 19, 2024

Description of your changes:

Based on this release the docker image of the metacontroller is being deprecated and need to be updated.

Checklist:

@biswassri biswassri changed the title chore: Update base image for metacontroller chore: Update image for metacontroller Dec 19, 2024
Copy link

Hi @biswassri. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

Copy link

Approvals successfully granted for pending runs.

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@juliusvonkohout
Copy link
Member

@HumairAK for approval

@juliusvonkohout
Copy link
Member

/assign @HumairAK

@HumairAK
Copy link
Collaborator

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 54b9a25 into kubeflow:master Dec 20, 2024
32 checks passed
google-oss-prow bot pushed a commit that referenced this pull request Feb 10, 2025
* Update cluster-role-binding.yaml

Signed-off-by: Julius von Kohout <[email protected]>

* Create cluster-role.yaml

Signed-off-by: juliusvonkohout <[email protected]>

* Update kustomization.yaml

Signed-off-by: juliusvonkohout <[email protected]>

* Update stateful-set.yaml

Signed-off-by: juliusvonkohout <[email protected]>

---------

Signed-off-by: Julius von Kohout <[email protected]>
Signed-off-by: juliusvonkohout <[email protected]>
@biswassri biswassri deleted the metacontroller-image branch February 18, 2025 21:50
HumairAK pushed a commit to HumairAK/data-science-pipelines that referenced this pull request Feb 28, 2025
…flow#11608)

* Update cluster-role-binding.yaml

Signed-off-by: Julius von Kohout <[email protected]>

* Create cluster-role.yaml

Signed-off-by: juliusvonkohout <[email protected]>

* Update kustomization.yaml

Signed-off-by: juliusvonkohout <[email protected]>

* Update stateful-set.yaml

Signed-off-by: juliusvonkohout <[email protected]>

---------

Signed-off-by: Julius von Kohout <[email protected]>
Signed-off-by: juliusvonkohout <[email protected]>
HumairAK pushed a commit to HumairAK/data-science-pipelines that referenced this pull request Feb 28, 2025
…flow#11608)

* Update cluster-role-binding.yaml

Signed-off-by: Julius von Kohout <[email protected]>

* Create cluster-role.yaml

Signed-off-by: juliusvonkohout <[email protected]>

* Update kustomization.yaml

Signed-off-by: juliusvonkohout <[email protected]>

* Update stateful-set.yaml

Signed-off-by: juliusvonkohout <[email protected]>

---------

(cherry picked from commit a40163f)

Signed-off-by: Julius von Kohout <[email protected]>
Signed-off-by: juliusvonkohout <[email protected]>
HumairAK pushed a commit to HumairAK/data-science-pipelines that referenced this pull request Feb 28, 2025
…flow#11608)

* Update cluster-role-binding.yaml

Signed-off-by: Julius von Kohout <[email protected]>

* Create cluster-role.yaml

Signed-off-by: juliusvonkohout <[email protected]>

* Update kustomization.yaml

Signed-off-by: juliusvonkohout <[email protected]>

* Update stateful-set.yaml

Signed-off-by: juliusvonkohout <[email protected]>

---------

(cherry picked from commit a40163f)

Signed-off-by: Julius von Kohout <[email protected]>
Signed-off-by: juliusvonkohout <[email protected]>
Signed-off-by: Humair Khan <[email protected]>
HumairAK added a commit that referenced this pull request Feb 28, 2025
* chore: Remove License checker (#11609)

* update dependencies

Signed-off-by: Humair Khan <[email protected]>

* remove license checking

Signed-off-by: Humair Khan <[email protected]>

---------

(cherry picked from commit c100648)

Signed-off-by: Humair Khan <[email protected]>

* fix(backend): Replaced hardcoded ServiceAccount with default config (#11578)

(cherry picked from commit 18641e1)

Signed-off-by: Helber Belmiro <[email protected]>
Signed-off-by: Humair Khan <[email protected]>

* fix(backend) fix run retry for argo (#11585)

(cherry picked from commit b131566)

Signed-off-by: arpechenin <[email protected]>
Signed-off-by: Humair Khan <[email protected]>

* fix(backend): parallelFor resolve upstream inputs. Fixes #11520 (#11627)

(cherry picked from commit f7c0616)

Signed-off-by: zazulam <[email protected]>
Signed-off-by: Humair Khan <[email protected]>

* fix(backend): the metacontroller is broken since #11474 (#11608)

* Update cluster-role-binding.yaml

Signed-off-by: Julius von Kohout <[email protected]>

* Create cluster-role.yaml

Signed-off-by: juliusvonkohout <[email protected]>

* Update kustomization.yaml

Signed-off-by: juliusvonkohout <[email protected]>

* Update stateful-set.yaml

Signed-off-by: juliusvonkohout <[email protected]>

---------

(cherry picked from commit a40163f)

Signed-off-by: Julius von Kohout <[email protected]>
Signed-off-by: juliusvonkohout <[email protected]>
Signed-off-by: Humair Khan <[email protected]>

* fix(manifests): Upgrading metacontroller to v4.11.22 (#11656)

(cherry picked from commit ebaaf75)

Signed-off-by: Tarek Abouzeid <[email protected]>
Signed-off-by: Humair Khan <[email protected]>

* fix(backend): ignore unknown fields for pb json unmarshaling (#11662)

(cherry picked from commit 9afe23e)

Signed-off-by: Humair Khan <[email protected]>

* chore: improved securitycontext for mysql (#11678)

* Update mysql-deployment.yaml

Signed-off-by: Julius von Kohout <[email protected]>

* Update mysql-deployment.yaml

Signed-off-by: Julius von Kohout <[email protected]>

* Update mysql-deployment.yaml

Signed-off-by: Julius von Kohout <[email protected]>

---------

(cherry picked from commit 78675b0)

Signed-off-by: Julius von Kohout <[email protected]>
Signed-off-by: Humair Khan <[email protected]>

* chore: partially revert 9afe23e (#11713)

In 9afe23e we introduced blackend dropping of unknown fields for
unmarshalling, but going forward we want to handle this more on a case
by case basis. In the case for driver we should drop them because by
this point the api server has declare the pipeline spec is acceptable,
so the driver should not fail here. As such we keep driver changes, but
revert those utilized by the api server.

(cherry picked from commit 13b8194)

Signed-off-by: Humair Khan <[email protected]>

* fix(backend) fix execution-level retry on the Argo Workflows backend (#11673)

(cherry picked from commit 30210e3)

Signed-off-by: ntny <[email protected]>
Signed-off-by: arpechenin <[email protected]>
Co-authored-by: arpechenin <[email protected]>
Signed-off-by: Humair Khan <[email protected]>

* Limit the number of parallel tests in SDK execution tests (#11680)

Often times, pods could not be scheduled because of insufficient CPU
and the worker would run out of disk space.

Signed-off-by: mprahl <[email protected]>
Signed-off-by: Humair Khan <[email protected]>

* correct kfp deploy images

Signed-off-by: Humair Khan <[email protected]>

---------

Signed-off-by: Humair Khan <[email protected]>
Signed-off-by: Helber Belmiro <[email protected]>
Signed-off-by: arpechenin <[email protected]>
Signed-off-by: zazulam <[email protected]>
Signed-off-by: Julius von Kohout <[email protected]>
Signed-off-by: juliusvonkohout <[email protected]>
Signed-off-by: Tarek Abouzeid <[email protected]>
Signed-off-by: ntny <[email protected]>
Signed-off-by: mprahl <[email protected]>
Co-authored-by: Helber Belmiro <[email protected]>
Co-authored-by: Anton Pechenin <[email protected]>
Co-authored-by: Michael <[email protected]>
Co-authored-by: Julius von Kohout <[email protected]>
Co-authored-by: Tarek Abouzeid <[email protected]>
Co-authored-by: arpechenin <[email protected]>
Co-authored-by: Matt Prahl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants