-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix(frontend): fixes optional pipeline inputs. Fixes #11632 #11657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @izuku-sds. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8970e02
to
c768c03
Compare
Signed-off-by: izuku-sds <[email protected]>
c768c03
to
1f342b6
Compare
Please review this PR. |
/ok-to-test |
Approvals successfully granted for pending runs. |
/lgtm Thank you! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
is this fix already released? @izuku-sds |
It'll be in the KFP 2.5 release which should be within the next few weeks. |
Description of your changes:
This PR resolves #11632
Optional pipeline inputs were incorrectly marked as a required field.
This fix ensures that the optional pipeline inputs are not marked as a required field.
Checklist: