Skip to content

test(backend): Add unit test for NewLauncherV2 #11854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2025
Merged

test(backend): Add unit test for NewLauncherV2 #11854

merged 1 commit into from
Jun 6, 2025

Conversation

jpthompson23
Copy link
Contributor

@jpthompson23 jpthompson23 commented Apr 23, 2025 •
edited
Loading

Description of your changes:

  • testing happy and unhappy paths for calling NewLauncherV2
  • adding ClientManager struct and ClientManagerInterface to enable dependency injection for NewLauncherV2

Checklist:

@google-oss-prow google-oss-prow bot requested review from gmfrasca and rimolive April 23, 2025 21:28
@google-oss-prow Google OSS Prow
Copy link

Hi @jpthompson23. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions GitHub Actions
Copy link

🚫 This command cannot be processed. Only organization members or owners can use the commands.

@jpthompson23 jpthompson23 changed the title test(backend): unit testing NewLauncherV2 [WIP] test(backend): unit testing NewLauncherV2 Apr 23, 2025
@jpthompson23 jpthompson23 force-pushed the unit-test-NewLauncherV2 branch from 1042e4f to f530630 Compare April 24, 2025 14:57
@jpthompson23 jpthompson23 mentioned this pull request Apr 24, 2025
Closed
2 tasks
@jpthompson23 jpthompson23 changed the title [WIP] test(backend): unit testing NewLauncherV2 test(backend): unit testing NewLauncherV2 Apr 24, 2025
@jpthompson23 jpthompson23 force-pushed the unit-test-NewLauncherV2 branch 2 times, most recently from dda99ec to 3d5897c Compare April 28, 2025 12:23
@hbelmiro
Copy link
Contributor

/ok-to-test

@github-actions GitHub Actions
Copy link

Approvals successfully granted for pending runs.

@jpthompson23 jpthompson23 force-pushed the unit-test-NewLauncherV2 branch 2 times, most recently from ca827f3 to a8a01f9 Compare April 28, 2025 19:15
@jpthompson23 jpthompson23 changed the title test(backend): unit testing NewLauncherV2 test(backend): Add unit test for NewLauncherV2 Apr 28, 2025
@jpthompson23
Copy link
Contributor Author

/retest

@jpthompson23 jpthompson23 force-pushed the unit-test-NewLauncherV2 branch 2 times, most recently from 7023bce to b96f205 Compare April 28, 2025 21:58
@hbelmiro
Copy link
Contributor

/ok-to-test

@github-actions GitHub Actions
Copy link

Approvals successfully granted for pending runs.

droctothorpe
droctothorpe approved these changes Apr 29, 2025
View reviewed changes
Copy link
Collaborator

@droctothorpe droctothorpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @jpthompson23. Kudos!

@google-oss-prow google-oss-prow bot added the lgtm label Apr 29, 2025
@jpthompson23 jpthompson23 force-pushed the unit-test-NewLauncherV2 branch from b96f205 to e3cb5c1 Compare May 1, 2025 12:02
@google-oss-prow google-oss-prow bot removed the lgtm label May 1, 2025
@hbelmiro
Copy link
Contributor

hbelmiro commented May 1, 2025

/ok-to-test

@github-actions GitHub Actions
Copy link

github-actions bot commented May 1, 2025

Approvals successfully granted for pending runs.

@HumairAK HumairAK moved this to In Review in KFP Project Tracker May 7, 2025
HumairAK
HumairAK reviewed May 7, 2025
View reviewed changes
@jpthompson23 jpthompson23 force-pushed the unit-test-NewLauncherV2 branch 6 times, most recently from 2dd4b97 to b77744e Compare May 30, 2025 18:35
@HumairAK
Copy link
Collaborator

HumairAK commented Jun 6, 2025

/lgtm
/approve

@jpthompson23 jpthompson23 force-pushed the unit-test-NewLauncherV2 branch from b77744e to 0bd6644 Compare June 6, 2025 18:54
@google-oss-prow google-oss-prow bot removed the lgtm label Jun 6, 2025
@HumairAK
Copy link
Collaborator

HumairAK commented Jun 6, 2025

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Jun 6, 2025
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 2b04d2f into kubeflow:master Jun 6, 2025
32 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in KFP Project Tracker Jun 6, 2025
@jpthompson23 jpthompson23 deleted the unit-test-NewLauncherV2 branch June 6, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HumairAK HumairAK HumairAK left review comments

@droctothorpe droctothorpe droctothorpe approved these changes

@gmfrasca gmfrasca Awaiting requested review from gmfrasca

@rimolive rimolive Awaiting requested review from rimolive

Assignees

@HumairAK HumairAK

@droctothorpe droctothorpe

Labels
approved lgtm ok-to-test size/L
Projects
KFP Project Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jpthompson23 @hbelmiro @HumairAK @droctothorpe