Skip to content

chore: Upgrade Argo Workflows to v3.6.7, bump golang version to v.1.24 #11944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

gmfrasca
Copy link
Member

Description of your changes:
Fixes #11789

Upgrade Argo Workflows dependencies and manifests to upstream v3.5.14

Non-trivial updates:

  • Upgrade of golang to v1.24
  • Add WorkflowTaskSet permissions to pipeline-runner role
  • Upgrade ControllerRuntime to v0.19.0
    • Introduced updates to PodClient interface, needed to be implemented/overridden for Faked clients

Checklist:

gmfrasca added 3 commits May 20, 2025 14:20
- Required by Argo Upgrade to v3.6.x
- Implements refactored functions in Faked clients

Signed-off-by: Giulio Frasca <[email protected]>
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chensun for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

- Updated linting causes CI to fail starting in Go1.24

Signed-off-by: Giulio Frasca <[email protected]>
@gmfrasca
Copy link
Member Author

Looks like the new golangci-lint action used in the pre-commit check, which was just added a couple weeks ago, only supports up to go version 1.23. So that check wont pass until the action itself is upgraded to use go1.24.2+, or the check is disabled.

@gmfrasca gmfrasca force-pushed the argo-367 branch 2 times, most recently from ad33fbc to 17adc5b Compare June 2, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(backend): Upgrade to Argo 3.6
1 participant