fix(ci): disable Unit and Integration Test - Go gh action in forked repos#2746
Conversation
milinddethe15
changed the title
Unit and Integration Test - Go gh action in forked reposUnit and Integration Test - Go gh action in forked repos
Pull Request Test Coverage Report for Build 16988430819Details
💛 - Coveralls |
andreyvelich
left a comment
andreyvelich
left a comment
There was a problem hiding this comment.
Sorry for the late reply @milinddethe15!
Do you see any problems to run this action in forked repos ?
Since this action uses the default runner, it should be fine as you can see in my fork: https://github.com/andreyvelich/trainer/actions/runs/16866735197/job/47774637459
|
Its not about passing/failing. The main thing is running the workflow in a forked repo is of no use (for most contributors) |
andreyvelich
left a comment
andreyvelich
left a comment
There was a problem hiding this comment.
Sounds good to me.
/lgtm
/assign @astefanutti @kubeflow/kubeflow-trainer-team
|
@milinddethe15 Can you rebase it please, so we can merge it ? |
|
Thanks for this, @milinddethe15! |
Signed-off-by: milinddethe15 <milinddethe15@gmail.com>
milinddethe15
force-pushed
the
fix/disable-github-actions
branch
from
80edaa9 to
0f743ad
Compare
|
PTAL |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
… repos (kubeflow#2746) Signed-off-by: milinddethe15 <milinddethe15@gmail.com>
4 participants
What this PR does / why we need it:
The workflow will only execute when running in the
kubeflow/trainerrepository and will be skipped in forks or other repositories.Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #2601
Checklist:
/cc @andreyvelich