fix(ci): Remove coverage from Go integration tests#2773
Merged
Conversation
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
andreyvelich
force-pushed
the
fix-coveralls
branch
from
be8331a to
ee7489c
Compare
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
andreyvelich
force-pushed
the
fix-coveralls
branch
from
acec1e5 to
cab268d
Compare
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Pull Request Test Coverage Report for Build 16738682517Details
💛 - Coveralls |
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Contributor
|
/lgtm Thanks |
Member
Author
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
alexxfan
pushed a commit
to red-hat-data-services/trainer
that referenced
this pull request
Nov 24, 2025
* fix(ci): Remove coverage from Go integration tests Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * Add debug step Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * Add finish Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * Fix the package name Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * Remove sed Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * Edit the go.mod Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * Create step Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * Fix name Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * Remove help script Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> --------- Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our coverage report looks to be broken: https://coveralls.io/github/kubeflow/trainer
I think, Go integration tests override the file, and it uploads empty report.
Coverage should be used only for unit tests, like in JobSet: https://github.com/kubernetes-sigs/jobset/blob/main/Makefile#L141
/assign @kubeflow/kubeflow-trainer-team @astefanutti