fix(manifests): Add missing permissions for the RuntimeClass and LimitRange#2787
Merged
Merged
Conversation
…tRange Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Pull Request Test Coverage Report for Build 16942765844Details
💛 - Coveralls |
Contributor
|
/lgtm Thanks! |
Comment on lines
+72
to
+73
| // +kubebuilder:rbac:groups=node.k8s.io,resources=runtimeclasses,verbs=get;list;watch | ||
| // +kubebuilder:rbac:groups="",resources=limitranges,verbs=get;list;watch |
Member
There was a problem hiding this comment.
Does the plugin also create/delete the resources ?
trainer/pkg/runtime/framework/plugins/coscheduling/coscheduling.go
Lines 232 to 238 in 9c2febd
Member
Author
There was a problem hiding this comment.
That is write operation for TrainJob.
The missing permissions are for LimitRange and RuntimeClass.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
alexxfan
pushed a commit
to red-hat-data-services/trainer
that referenced
this pull request
Nov 24, 2025
…tRange (kubeflow#2787) Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Even though podgroup plugin needs to operate LimitRange and RuntimeClass, the trainer does not have proper permissions.
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #
Checklist: