Skip to content

feat: add HF token and allow gpu workflow to run from pull request#2817

Closed
jaiakash wants to merge 3 commits into
kubeflow:masterfrom
jaiakash:gpu-test-on-pr
Closed

feat: add HF token and allow gpu workflow to run from pull request#2817
jaiakash wants to merge 3 commits into
kubeflow:masterfrom
jaiakash:gpu-test-on-pr

Conversation

@jaiakash

@jaiakash jaiakash commented Sep 4, 2025

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Which issue(s) this PR fixes :
Fixes #2814

Checklist:

  • Docs included if any changes are user facing

…rget

Signed-off-by: Akash Jaiswal <akashjaiswal3846@gmail.com>
@coveralls

coveralls commented Sep 4, 2025

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 17474656673

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 52.136%

Totals Coverage Status
Change from base Build 17469034215: 0.0%
Covered Lines: 1025
Relevant Lines: 1966

💛 - Coveralls


env:
GOPATH: ${{ github.workspace }}/go
HF_TOKEN: ${{ secrets.HF_TOKEN }}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed, we also need to update the checkout action to ensure that it takes the latest changes from the PR:

- uses: actions/checkout@v4
  with:
    ref: ${{ github.event.pull_request.head.sha }}

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, Updated it.

@google-oss-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gaocegege for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Akash Jaiswal <akashjaiswal3846@gmail.com>
Signed-off-by: Akash Jaiswal <akashjaiswal3846@gmail.com>
@jaiakash jaiakash closed this Sep 4, 2025
@jaiakash jaiakash deleted the gpu-test-on-pr branch September 4, 2025 19:31
@jaiakash jaiakash restored the gpu-test-on-pr branch September 4, 2025 19:31
@jaiakash

jaiakash commented Sep 4, 2025

Copy link
Copy Markdown
Member Author

Closed this, Please check #2818

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: gpu e2e test to run on pull_request_target and use kubeflow/trainer secret

3 participants