Skip to content

[release-2.0] fix: update kubeflow sdk reference (#2780)#2847

Merged
tenzen-y merged 1 commit into
kubeflow:release-2.0from
astefanutti:cherry-pick-2780
Sep 23, 2025
Merged

[release-2.0] fix: update kubeflow sdk reference (#2780)#2847
tenzen-y merged 1 commit into
kubeflow:release-2.0from
astefanutti:cherry-pick-2780

Conversation

@astefanutti
Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Manual cherry-pick of #2780 in release-2.0 branch.

Checklist:

  • Docs included if any changes are user facing

@google-oss-prow google-oss-prow Bot added this to the v2.0 milestone Sep 23, 2025
@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign electronic-waste for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: kramaranya <kramaranya15@gmail.com>
Signed-off-by: Antonin Stefanutti <antonin@stefanutti.fr>
@coveralls
Copy link
Copy Markdown

coveralls commented Sep 23, 2025

Pull Request Test Coverage Report for Build 17943132976

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 30.323%

Totals Coverage Status
Change from base Build 16728116777: 0.0%
Covered Lines: 947
Relevant Lines: 3123

💛 - Coveralls

@astefanutti
Copy link
Copy Markdown
Contributor Author

The e2e test workflows fail with the following error:

NameError                                 Traceback (most recent call last)
Cell In[7], line 14
      1 job_name = client.train(
      2     trainer=CustomTrainer(
      3         func=train_fashion_mnist,
      4         # Set how many PyTorch nodes you want to use for distributed training.
      5         num_nodes=3,
      6         # Set the resources for each PyTorch node.
      7         resources_per_node={
      8             "cpu": 3,
      9             "memory": "16Gi",
     10             # Uncomment this to distribute the TrainJob using GPU nodes.
     11             # "nvidia.com/gpu": 1,
     12         },
     13     ),
---> 14     runtime=torch_runtime,
     15 )

NameError: name 'torch_runtime' is not defined

I don't think it's related to this PR and the changes introduced from cherry-picking #2780 so that may be better to merge this and fix the remaining issues separately.

@tenzen-y
Copy link
Copy Markdown
Member

cc @kramaranya @andreyvelich

@tenzen-y
Copy link
Copy Markdown
Member

Manually merging this PR as #2847 (comment)

@tenzen-y tenzen-y merged commit 8425183 into kubeflow:release-2.0 Sep 23, 2025
17 of 23 checks passed
@astefanutti astefanutti deleted the cherry-pick-2780 branch September 23, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants