Skip to content

feat: Add PodTemplateOverrides into TrainJob V2 API#2882

Merged
google-oss-prow[bot] merged 1 commit into
kubeflow:masterfrom
xigang:proposal-2170
Oct 9, 2025
Merged

feat: Add PodTemplateOverrides into TrainJob V2 API#2882
google-oss-prow[bot] merged 1 commit into
kubeflow:masterfrom
xigang:proposal-2170

Conversation

@xigang

@xigang xigang commented Oct 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes ##2785

@xigang

xigang commented Oct 8, 2025

Copy link
Copy Markdown
Contributor Author

/cc @astefanutti @andreyvelich @tenzen-y

@xigang xigang changed the title docs: Add PodTemplateOverrides into TrainJob V2 API feat: Add PodTemplateOverrides into TrainJob V2 API Oct 8, 2025
@astefanutti

astefanutti commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

/lgtm

Thanks @xigang.

@google-oss-prow google-oss-prow Bot added the lgtm label Oct 8, 2025
andreyvelich
andreyvelich reviewed Oct 9, 2025
View reviewed changes

@andreyvelich andreyvelich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xigang!
Please can you update the implementation history: https://github.com/kubeflow/trainer/blob/f7503ed41ae1ee69ae3932cde3282cd6ca61a6a8/docs/proposals/2170-kubeflow-trainer-v2/README.md#implementation-history

@coveralls

coveralls commented Oct 9, 2025 •
edited
Loading

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 18374533936

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 54.488%
Totals Coverage Status
Change from base Build 18372863772: 0.0%
Covered Lines: 1214
Relevant Lines: 2228
💛 - Coveralls

@xigang
docs: Add PodTemplateOverrides into TrainJob V2 API
cd64fba 
Signed-off-by: xigang <wangxigang2014@gmail.com>
@google-oss-prow google-oss-prow Bot removed the lgtm label Oct 9, 2025
@xigang

xigang commented Oct 9, 2025

Copy link
Copy Markdown
Contributor Author

@andreyvelich Implementation history has been added.

andreyvelich
andreyvelich reviewed Oct 9, 2025
View reviewed changes

@andreyvelich andreyvelich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xigang!
/lgtm
/approve

@google-oss-prow google-oss-prow Bot added the lgtm label Oct 9, 2025
@google-oss-prow

google-oss-prow Bot commented Oct 9, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot merged commit 2256a81 into kubeflow:master Oct 9, 2025
26 of 27 checks passed
@google-oss-prow google-oss-prow Bot added this to the v2.1 milestone Oct 9, 2025
alexxfan pushed a commit to red-hat-data-services/trainer that referenced this pull request Nov 24, 2025
@xigang @alexxfan
feat: Add PodTemplateOverrides into TrainJob V2 API (kubeflow#2882)
13b2f21 
Signed-off-by: xigang <wangxigang2014@gmail.com>
mahdikhashan pushed a commit to mahdikhashan/trainer that referenced this pull request Dec 29, 2025
@xigang @mahdikhashan
feat: Add PodTemplateOverrides into TrainJob V2 API (kubeflow#2882)
0bc51fe 
Signed-off-by: xigang <wangxigang2014@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreyvelich andreyvelich andreyvelich left review comments

@jinchihe jinchihe Awaiting requested review from jinchihe

@kuizhiqing kuizhiqing Awaiting requested review from kuizhiqing

@astefanutti astefanutti Awaiting requested review from astefanutti

@tenzen-y tenzen-y Awaiting requested review from tenzen-y

Assignees

@astefanutti astefanutti

@andreyvelich andreyvelich

Labels

approved lgtm size/L

Projects

None yet

Milestone

v2.1

Development

Successfully merging this pull request may close these issues.

4 participants

@xigang @astefanutti @coveralls @andreyvelich