Remove container runtime related code #1812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Waleed Malik <[email protected]>
Signed-off-by: Waleed Malik <[email protected]>
kubermatic-bot
added
docs/tbd
Signed-off-by: Waleed Malik <[email protected]>
kubermatic-bot
added
size/XXL
Signed-off-by: Waleed Malik <[email protected]>
|
/approve |
|
LGTM label has been added. Git tree hash: 6154f08bc7e0a1c30b30ee582a4fec6bae5bb5ab
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
kubermatic-bot
added
docs/none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Remove container runtime-related code since it will be moved to operating-system-manager. The
node-flags have been deprecated since machine-controller can no longer control those configurations as it doesn't generate the user data.I have also removed flags that have been in a deprecated state for more than a year.
Which issue(s) this PR fixes:
Fixes #
What type of PR is this?
/kind cleanup
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: