Skip to content

replace packethost/packngo with equinix SDK #1871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2024
Merged

replace packethost/packngo with equinix SDK #1871

merged 1 commit into from
Nov 4, 2024

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Oct 21, 2024 •
edited
Loading

What this PR does / why we need it:
This replaces one Go package with another.

Which issue(s) this PR fixes:
part of kubermatic/kubermatic#13631

What type of PR is this?
/kind feature

Does this PR introduce a user-facing change? Then add your Release Note here:

Use official Equinix SDK instead of deprecated packethost/packngo.

Documentation:

None

@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 21, 2024
@xrstf xrstf marked this pull request as draft October 21, 2024 16:32
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2024
@xrstf xrstf force-pushed the update-equinix-sdk branch from dd60f9b to 0f32296 Compare October 21, 2024 16:32
@xrstf
Copy link
Contributor Author

xrstf commented Oct 21, 2024

/test pull-machine-controller-e2e-equinix-metal

@xrstf xrstf marked this pull request as ready for review October 21, 2024 17:42
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2024
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8b320dd66077975ac137dd163680cf982501892e

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2024
@kubermatic-bot kubermatic-bot merged commit 36a68f1 into kubermatic:main Nov 4, 2024
14 checks passed
@xrstf xrstf deleted the update-equinix-sdk branch November 5, 2024 12:03
@xrstf xrstf mentioned this pull request Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xrstf @kubermatic-bot @ahmedwaleedmalik