-
Notifications
You must be signed in to change notification settings - Fork 135
Fix bug with handling server types and add new Hetzner server types #1877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Adonis Murati <[email protected]>
Skipping CI for Draft Pull Request. |
/test pull-machine-controller-e2e-hetzner |
Signed-off-by: Adonis Murati <[email protected]>
Signed-off-by: Adonis Murati <[email protected]>
/test pull-machine-controller-e2e-hetzner |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 4b4a05e9aef74c19184e698251f797753b0fdb52
|
/cherry-pick release/v1.60 |
@ahmedwaleedmalik: new pull request created: #1884 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick release/v1.59 |
/cherry-pick release/v1.58 |
@ahmedwaleedmalik: #1877 failed to apply on top of branch "release/v1.59":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@ahmedwaleedmalik: #1877 failed to apply on top of branch "release/v1.58":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I don't really know if this is required for 1.59 and 1.58 or not. For now, we just need this for #1883 |
What this PR does / why we need it:
Fixes handling Hetzner server types. When no error was returned while we were running prowjobs in Hetzner, Hetzner client was returning a nil server type, we had no check for this, which later resulted in test failures after Hetzner had deprecated support for cx11 server types.
This pr also adds cx22 to server types for our e2e tests, after Hetzner deprecation of cx11: https://docs.hetzner.com/cloud/servers/deprecated-plans/
Which issue(s) this PR fixes:
Fixes #
What type of PR is this?
/kind bug
/kind chore
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: